Commit ead247c1 authored by Dan Elphick's avatar Dan Elphick Committed by Commit Bot

Delete redundant code in OptimizingCompileDispatcher::Stop

Removes job queue flushing in OptimizingCompileDispatcher::Stop when
FLAG_concurrent_recompilation_delay is set. Before this explicit
flushing was run, there was already a wait-loop which ensured the queue
was always empty.

Bug: v8:9810
Change-Id: I620bac9c9d73aead671b178c9450bdd25e6761b1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1934332
Commit-Queue: Dan Elphick <delphick@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Auto-Submit: Dan Elphick <delphick@chromium.org>
Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65154}
parent f53c728f
...@@ -193,14 +193,10 @@ void OptimizingCompileDispatcher::Stop() { ...@@ -193,14 +193,10 @@ void OptimizingCompileDispatcher::Stop() {
mode_ = COMPILE; mode_ = COMPILE;
} }
if (recompilation_delay_ != 0) {
// At this point the optimizing compiler thread's event loop has stopped. // At this point the optimizing compiler thread's event loop has stopped.
// There is no need for a mutex when reading input_queue_length_. // There is no need for a mutex when reading input_queue_length_.
while (input_queue_length_ > 0) CompileNext(NextInput()); DCHECK_EQ(input_queue_length_, 0);
InstallOptimizedFunctions();
} else {
FlushOutputQueue(false); FlushOutputQueue(false);
}
} }
void OptimizingCompileDispatcher::InstallOptimizedFunctions() { void OptimizingCompileDispatcher::InstallOptimizedFunctions() {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment