Commit ea750ba6 authored by Jakob Kummerow's avatar Jakob Kummerow Committed by Commit Bot

[mac][asan][tests] Fix inspector/runtime/remote-object

Since one of the latest Clang rolls, ASan builds on MacOS appear
to be using bigger stack frames, so reduce the maximum recursion
depth a bit in that configuration.

Fixed: v8:11176
Change-Id: I00942194a6c4d8046ec6abd24219912ebd153e57
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563465
Auto-Submit: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71501}
parent 2bbf3333
...@@ -215,7 +215,13 @@ Response toProtocolValue(v8::Local<v8::Context> context, ...@@ -215,7 +215,13 @@ Response toProtocolValue(v8::Local<v8::Context> context,
v8::Local<v8::Value> value, v8::Local<v8::Value> value,
std::unique_ptr<protocol::Value>* result) { std::unique_ptr<protocol::Value>* result) {
if (value->IsUndefined()) return Response::Success(); if (value->IsUndefined()) return Response::Success();
return toProtocolValue(context, value, 1000, result); #if defined(V8_USE_ADDRESS_SANITIZER) && V8_OS_MACOSX
// For whatever reason, ASan on MacOS has bigger stack frames.
static const int kMaxDepth = 900;
#else
static const int kMaxDepth = 1000;
#endif
return toProtocolValue(context, value, kMaxDepth, result);
} }
enum AbbreviateMode { kMiddle, kEnd }; enum AbbreviateMode { kMiddle, kEnd };
......
...@@ -170,9 +170,6 @@ ...@@ -170,9 +170,6 @@
# There are still memory leaks in some inspector tests # There are still memory leaks in some inspector tests
# (https://crbug.com/v8/11107). # (https://crbug.com/v8/11107).
'runtime/evaluate-async': [SKIP], 'runtime/evaluate-async': [SKIP],
# https://crbug.com/v8/11176.
'runtime/remote-object' : [SKIP],
}], # asan == True }], # asan == True
] ]
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment