Commit e93e4dad authored by machenbach's avatar machenbach Committed by Commit bot

Revert of Reland [android] Migrate more configs to gyp. (patchset #2 id:20001...

Revert of Reland [android] Migrate more configs to gyp. (patchset #2 id:20001 of https://codereview.chromium.org/1210393003/)

Reason for revert:
[Sheriff] Fails runhooks.

Original issue's description:
> Reland [android] Migrate more configs to gyp.
>
> This reverts commit 3e8892b5.
>
> BUG=chromium:502176
> LOG=n
> NOTRY=true
> TBR=ulan@chromium.org, jochen@chromium.org
>
> Committed: https://crrev.com/c0d70e43c4cbe2a09c8f1bd55fe2be03cd9ba041
> Cr-Commit-Position: refs/heads/master@{#29317}

TBR=ulan@chromium.org,jochen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:502176

Review URL: https://codereview.chromium.org/1215593004

Cr-Commit-Position: refs/heads/master@{#29319}
parent 57d1c91c
...@@ -35,24 +35,28 @@ MODES = release debug ...@@ -35,24 +35,28 @@ MODES = release debug
ANDROID_BUILDS = $(foreach mode,$(MODES), \ ANDROID_BUILDS = $(foreach mode,$(MODES), \
$(addsuffix .$(mode),$(ANDROID_ARCHES))) $(addsuffix .$(mode),$(ANDROID_ARCHES)))
HOST_OS = $(shell uname -s | sed -e 's/Linux/linux/;s/Darwin/mac/')
ifeq ($(ARCH), android_arm) ifeq ($(ARCH), android_arm)
DEFINES = target_arch=arm v8_target_arch=arm DEFINES = target_arch=arm v8_target_arch=arm android_target_arch=arm android_target_platform=16
DEFINES += arm_neon=0 arm_version=7
else ifeq ($(ARCH), android_arm64) else ifeq ($(ARCH), android_arm64)
DEFINES = target_arch=arm64 v8_target_arch=arm64 DEFINES = target_arch=arm64 v8_target_arch=arm64 android_target_arch=arm64 android_target_platform=21
else ifeq ($(ARCH), android_mipsel) else ifeq ($(ARCH), android_mipsel)
DEFINES = target_arch=mipsel v8_target_arch=mipsel DEFINES = target_arch=mipsel v8_target_arch=mipsel android_target_platform=16
DEFINES += android_target_arch=mips mips_arch_variant=mips32r2
else ifeq ($(ARCH), android_ia32) else ifeq ($(ARCH), android_ia32)
DEFINES = target_arch=ia32 v8_target_arch=ia32 DEFINES = target_arch=ia32 v8_target_arch=ia32 android_target_arch=x86 android_target_platform=16
else ifeq ($(ARCH), android_x64) else ifeq ($(ARCH), android_x64)
DEFINES = target_arch=x64 v8_target_arch=x64 DEFINES = target_arch=x64 v8_target_arch=x64 android_target_arch=x86_64 android_target_platform=21
else ifeq ($(ARCH), android_x87) else ifeq ($(ARCH), android_x87)
DEFINES = target_arch=ia32 v8_target_arch=x87 DEFINES = target_arch=x87 v8_target_arch=x87 android_target_arch=x86 android_target_platform=16
else else
$(error Target architecture "${ARCH}" is not supported) $(error Target architecture "${ARCH}" is not supported)
endif endif
# Common flags. # Common flags.
DEFINES += OS=android DEFINES += host_os=${HOST_OS} OS=android
.SECONDEXPANSION: .SECONDEXPANSION:
$(ANDROID_BUILDS): $(OUTDIR)/Makefile.$$@ $(ANDROID_BUILDS): $(OUTDIR)/Makefile.$$@
......
...@@ -222,50 +222,31 @@ ...@@ -222,50 +222,31 @@
# Copy conditionally-set variables out one scope. # Copy conditionally-set variables out one scope.
'android_ndk_root%': '<(android_ndk_root)', 'android_ndk_root%': '<(android_ndk_root)',
'host_os%': '<(host_os)',
'conditions': [ 'conditions': [
['target_arch == "ia32"', { ['target_arch == "ia32"', {
'android_toolchain%': '<(android_ndk_root)/toolchains/x86-4.9/prebuilt/<(host_os)-<(android_host_arch)/bin', 'android_toolchain%': '<(android_ndk_root)/toolchains/x86-4.9/prebuilt/<(host_os)-<(android_host_arch)/bin',
'android_target_arch%': 'x86',
'android_target_platform%': '16',
}], }],
['target_arch == "x64"', { ['target_arch == "x64"', {
'android_toolchain%': '<(android_ndk_root)/toolchains/x86_64-4.9/prebuilt/<(host_os)-<(android_host_arch)/bin', 'android_toolchain%': '<(android_ndk_root)/toolchains/x86_64-4.9/prebuilt/<(host_os)-<(android_host_arch)/bin',
'android_target_arch%': 'x86_64',
'android_target_platform%': '21',
}], }],
['target_arch=="arm"', { ['target_arch=="arm"', {
'android_toolchain%': '<(android_ndk_root)/toolchains/arm-linux-androideabi-4.9/prebuilt/<(host_os)-<(android_host_arch)/bin', 'android_toolchain%': '<(android_ndk_root)/toolchains/arm-linux-androideabi-4.9/prebuilt/<(host_os)-<(android_host_arch)/bin',
'android_target_arch%': 'arm',
'android_target_platform%': '16',
'arm_version%': 7,
}], }],
['target_arch == "arm64"', { ['target_arch == "arm64"', {
'android_toolchain%': '<(android_ndk_root)/toolchains/aarch64-linux-android-4.9/prebuilt/<(host_os)-<(android_host_arch)/bin', 'android_toolchain%': '<(android_ndk_root)/toolchains/aarch64-linux-android-4.9/prebuilt/<(host_os)-<(android_host_arch)/bin',
'android_target_arch%': 'arm64',
'android_target_platform%': '21',
'arm_version%': 'default',
}], }],
['target_arch == "mipsel"', { ['target_arch == "mipsel"', {
'android_toolchain%': '<(android_ndk_root)/toolchains/mipsel-linux-android-4.9/prebuilt/<(host_os)-<(android_host_arch)/bin', 'android_toolchain%': '<(android_ndk_root)/toolchains/mipsel-linux-android-4.9/prebuilt/<(host_os)-<(android_host_arch)/bin',
'android_target_arch%': 'mips',
'android_target_platform%': '16',
}], }],
['target_arch == "mips64el"', { ['target_arch == "mips64el"', {
'android_toolchain%': '<(android_ndk_root)/toolchains/mips64el-linux-android-4.9/prebuilt/<(host_os)-<(android_host_arch)/bin', 'android_toolchain%': '<(android_ndk_root)/toolchains/mips64el-linux-android-4.9/prebuilt/<(host_os)-<(android_host_arch)/bin',
'android_target_arch%': 'mips64',
'android_target_platform%': '21',
}], }],
], ],
}, },
# Copy conditionally-set variables out one scope. # Copy conditionally-set variables out one scope.
'android_target_arch%': '<(android_target_arch)',
'android_target_platform%': '<(android_target_platform)',
'android_toolchain%': '<(android_toolchain)', 'android_toolchain%': '<(android_toolchain)',
'arm_version%': '<(arm_version)',
'host_os%': '<(host_os)',
'conditions': [ 'conditions': [
['android_ndk_root==""', { ['android_ndk_root==""', {
...@@ -311,6 +292,7 @@ ...@@ -311,6 +292,7 @@
}], }],
], ],
# Default ARM variable settings. # Default ARM variable settings.
'arm_version%': 'default',
'arm_fpu%': 'vfpv3', 'arm_fpu%': 'vfpv3',
'arm_float_abi%': 'default', 'arm_float_abi%': 'default',
'arm_thumb': 'default', 'arm_thumb': 'default',
...@@ -328,11 +310,6 @@ ...@@ -328,11 +310,6 @@
'target_defaults': { 'target_defaults': {
'variables': { 'variables': {
'v8_code%': '<(v8_code)', 'v8_code%': '<(v8_code)',
'conditions':[
['OS=="android"', {
'host_os%': '<(host_os)',
}],
],
}, },
'default_configuration': 'Debug', 'default_configuration': 'Debug',
'configurations': { 'configurations': {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment