Commit e8c5444f authored by Georg Neis's avatar Georg Neis Committed by Commit Bot

[turbofan] Adapt and reenable a long forgotten test

Change-Id: I20d5d22e424bf2327e201afe4d395939a862bdcd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2218057
Auto-Submit: Georg Neis <neis@chromium.org>
Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68032}
parent 707ef575
......@@ -217,8 +217,6 @@ static IrOpcode::Value NumberToI32(bool is_signed) {
}
// TODO(turbofan): Lowering of StringAdd is disabled for now.
#if 0
TEST(StringBinops) {
JSTypedLoweringTester R;
......@@ -228,16 +226,15 @@ TEST(StringBinops) {
for (size_t j = 0; j < arraysize(kStringTypes); ++j) {
Node* p1 = R.Parameter(kStringTypes[j], 1);
Node* add = R.Binop(R.javascript.Add(), p0, p1);
Node* add = R.Binop(R.javascript.Add(BinaryOperationHint::kAny), p0, p1);
Node* r = R.reduce(add);
R.CheckBinop(IrOpcode::kStringAdd, r);
CHECK_EQ(p0, r->InputAt(0));
CHECK_EQ(p1, r->InputAt(1));
R.CheckBinop(IrOpcode::kStringConcat, r);
CHECK_EQ(p0, r->InputAt(1));
CHECK_EQ(p1, r->InputAt(2));
}
}
}
#endif
TEST(AddNumber1) {
JSTypedLoweringTester R;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment