Commit e88e668e authored by machenbach's avatar machenbach Committed by Commit bot

Revert of [foozzie] Pass startup test (patchset #1 id:1 of...

Revert of [foozzie] Pass startup test (patchset #1 id:1 of https://codereview.chromium.org/2623743004/ )

Reason for revert:
Setting the BAD_BUILDS_CHECK env variable should
be enough. Lets revert this as the code doesn't
look particularly good. There must be another
problem still that needs investigation.

Original issue's description:
> [foozzie] Pass startup test
>
> This makes sure the harness passes when called without test case.
>
> BUG=chromium:673246
> NOTRY=true
> TBR=tandrii@chromium.org,mbarbella@chromium.org
>
> Review-Url: https://codereview.chromium.org/2623743004
> Cr-Commit-Position: refs/heads/master@{#42183}
> Committed: https://chromium.googlesource.com/v8/v8/+/ede2fc1ff04ff97a466029b0ad52d3ec94780407

TBR=tandrii@chromium.org,mbarbella@chromium.org,mmoroz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:673246

Review-Url: https://codereview.chromium.org/2628493003
Cr-Commit-Position: refs/heads/master@{#42189}
parent 6921b71d
......@@ -101,13 +101,9 @@ def parse_args():
parser.add_argument(
'--second-d8',
help='optional path to second d8 executable, default: same as first')
parser.add_argument('testcase', help='path to test case', nargs='?')
parser.add_argument('testcase', help='path to test case')
options = parser.parse_args()
if not options.testcase:
# Don't check further as we want to bail out early without test case.
return options
# Ensure we make a sane comparison.
assert (options.first_arch != options.second_arch or
options.first_config != options.second_config) , (
......@@ -189,10 +185,6 @@ def fail_bailout(output, ignore_by_output_fun):
def main():
options = parse_args()
if not options.testcase:
print '# V8 correctness - pass - no test file given'
return RETURN_PASS
# Suppressions are architecture and configuration specific.
suppress = v8_suppressions.get_suppression(
options.first_arch, options.first_config,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment