Skip to content

V
V8
Commit e7e7124c authored by machenbach's avatar machenbach Committed by Commit bot
Browse files
Options

[build] Fix empty action inputs for xcode-ninja builds 

BUG=chromium:606898
LOG=n

Review-Url: https://codereview.chromium.org/1932703002
Cr-Commit-Position: refs/heads/master@{#35860}
parent 914c6c52
Hide whitespace changes
Inline Side-by-side
Showing with 22 additions and 4 deletions
src/v8.gyp
View file @ e7e7124c
...@@ -192,8 +192,18 @@ ...@@ -192,8 +192,18 @@
'action_name': 'run_mksnapshot', 'action_name': 'run_mksnapshot',
'inputs': [ 'inputs': [
'<(mksnapshot_exec)', '<(mksnapshot_exec)',
'<(embed_script)', ],
'<(warmup_script)', 'conditions': [
['embed_script!=""', {
'inputs': [
'<(embed_script)',
],
}],
['warmup_script!=""', {
'inputs': [
'<(warmup_script)',
],
}],
], ],
'outputs': [ 'outputs': [
'<(INTERMEDIATE_DIR)/snapshot.cc', '<(INTERMEDIATE_DIR)/snapshot.cc',
...@@ -299,8 +309,6 @@ ...@@ -299,8 +309,6 @@
'action_name': 'run_mksnapshot (external)', 'action_name': 'run_mksnapshot (external)',
'inputs': [ 'inputs': [
'<(mksnapshot_exec)', '<(mksnapshot_exec)',
'<(embed_script)',
'<(warmup_script)',
], ],
'variables': { 'variables': {
'mksnapshot_flags': [], 'mksnapshot_flags': [],
...@@ -314,6 +322,16 @@ ...@@ -314,6 +322,16 @@
], ],
}, },
'conditions': [ 'conditions': [
['embed_script!=""', {
'inputs': [
'<(embed_script)',
],
}],
['warmup_script!=""', {
'inputs': [
'<(warmup_script)',
],
}],
['want_separate_host_toolset==1', { ['want_separate_host_toolset==1', {
'target_conditions': [ 'target_conditions': [
['_toolset=="host"', { ['_toolset=="host"', {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment