[cleanup] Update field type on root maps in-place.

The field type can always be generalized in-place, even for root maps.
There's no need to create defensive copies in this case. This happens
for example in the superWrapper in the Speedometer2/EmberJS-Debug test.

Bug: v8:8834, v8:9114
Change-Id: Ief05516d0e9d84850c52d2cf8815953ef77d5223
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1562131
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60778}

src/map-updater.cc

@@ -362,19 +362,12 @@ MapUpdater::State MapUpdater::FindRootMap() {
     DCHECK_EQ(kData, old_details.kind());
     DCHECK_EQ(kData, new_kind_);
     DCHECK_EQ(kField, new_location_);
-    FieldType old_field_type =
-        old_descriptors_->GetFieldType(modified_descriptor_);
-    if (!new_field_type_->NowIs(old_field_type)) {
-      return CopyGeneralizeAllFields("GenAll_RootModification5");
-    }
 
-    // Modify root map in-place.
-    if (new_constness_ != old_details.constness()) {
-      DCHECK(IsGeneralizableTo(old_details.constness(), new_constness_));
-      GeneralizeField(old_map_, modified_descriptor_, new_constness_,
-                      old_details.representation(),
-                      handle(old_field_type, isolate_));
-    }
+    // Modify root map in-place. The GeneralizeField method is a no-op
+    // if the {old_map_} is already general enough to hold the requested
+    // {new_constness_} and {new_field_type_}.
+    GeneralizeField(old_map_, modified_descriptor_, new_constness_,
+                    old_details.representation(), new_field_type_);
   }
 
   // From here on, use the map with correct elements kind as root map.