Commit e69fa726 authored by Leon Bettscheider's avatar Leon Bettscheider Committed by V8 LUCI CQ

[heap] Fix regression in IncrementalMarkingJob::ScheduleTask

This CL fixes a regression caused by https://crrev.com/c/3865147.

Bug: v8:13012
Change-Id: I2a0b89965a305197b499044ea7b10285a763dc4d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3871296
Commit-Queue: Leon Bettscheider <bettscheider@google.com>
Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82948}
parent de762c96
......@@ -41,8 +41,7 @@ void IncrementalMarkingJob::ScheduleTask() {
base::MutexGuard guard(&mutex_);
if (is_task_pending_ || heap_->IsTearingDown() ||
!FLAG_incremental_marking_task ||
!heap_->incremental_marking()->IsMajorMarking()) {
!FLAG_incremental_marking_task) {
return;
}
......@@ -101,7 +100,7 @@ void IncrementalMarkingJob::Task::RunInternal() {
heap->incremental_marking()->AdvanceAndFinalizeIfComplete();
if (incremental_marking->IsMarking()) {
if (incremental_marking->IsMajorMarking()) {
// TODO(v8:12775): It is quite suprising that we schedule the task
// immediately here. This was introduced since delayed task were
// unreliable at some point. Investigate whether this is still the case
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment