Commit e632f8f4 authored by Michael Achenbach's avatar Michael Achenbach Committed by Commit Bot

[test] Remove longer timeout on bots

CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux_gc_stress_dbg
CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux_gcc_rel
CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux64_msan_rel
CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux64_tsan_rel
CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux_arm64_dbg
CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_mac64_asan_rel
CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_win64_dbg
CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_android_arm64_n5x_rel_ng
CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux64_cfi_rel_ng
CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux64_ubsan_rel_ng
CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux_arm_lite_rel_ng
CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux_noi18n_rel_ng
CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_mac64_dbg_ng

Bug: v8:9145
Change-Id: I6efee8579d9d9e0aad0431f6b87c152141d4ec7f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581261
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: 's avatarTamer Tas <tmrts@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61107}
parent 9284ad57
...@@ -309,6 +309,7 @@ ...@@ -309,6 +309,7 @@
# Slow tests. # Slow tests.
'array-constructor': [PASS, SLOW], 'array-constructor': [PASS, SLOW],
'json': [PASS, SLOW], 'json': [PASS, SLOW],
'large-object-literal-slow-elements': [PASS, SLOW],
# BUG(v8:4779): Crashes flakily with stress mode on arm64. # BUG(v8:4779): Crashes flakily with stress mode on arm64.
'array-splice': [PASS, SLOW, ['arch == arm64', NO_VARIANTS]], 'array-splice': [PASS, SLOW, ['arch == arm64', NO_VARIANTS]],
......
...@@ -190,6 +190,7 @@ class BuildConfig(object): ...@@ -190,6 +190,7 @@ class BuildConfig(object):
self.no_snap = not build_config['v8_use_snapshot'] self.no_snap = not build_config['v8_use_snapshot']
self.predictable = build_config['v8_enable_verify_predictable'] self.predictable = build_config['v8_enable_verify_predictable']
self.tsan = build_config['is_tsan'] self.tsan = build_config['is_tsan']
# TODO(machenbach): We only have ubsan not ubsan_vptr.
self.ubsan_vptr = build_config['is_ubsan_vptr'] self.ubsan_vptr = build_config['is_ubsan_vptr']
self.embedded_builtins = build_config['v8_enable_embedded_builtins'] self.embedded_builtins = build_config['v8_enable_embedded_builtins']
self.verify_csa = build_config['v8_enable_verify_csa'] self.verify_csa = build_config['v8_enable_verify_csa']
...@@ -200,6 +201,11 @@ class BuildConfig(object): ...@@ -200,6 +201,11 @@ class BuildConfig(object):
self.mips_arch_variant = build_config['mips_arch_variant'] self.mips_arch_variant = build_config['mips_arch_variant']
self.mips_use_msa = build_config['mips_use_msa'] self.mips_use_msa = build_config['mips_use_msa']
@property
def use_sanitizer(self):
return (self.asan or self.cfi_vptr or self.msan or self.tsan or
self.ubsan_vptr)
def __str__(self): def __str__(self):
detected_options = [] detected_options = []
...@@ -693,10 +699,6 @@ class BaseTestRunner(object): ...@@ -693,10 +699,6 @@ class BaseTestRunner(object):
} }
def _create_test_config(self, options): def _create_test_config(self, options):
# TODO(machenbach): Remove temporary hard-coded timeout when infra side is
# removed.
if options.buildbot:
options.timeout = 200
timeout = options.timeout * self._timeout_scalefactor(options) timeout = options.timeout * self._timeout_scalefactor(options)
return TestConfig( return TestConfig(
command_prefix=options.command_prefix, command_prefix=options.command_prefix,
...@@ -713,15 +715,16 @@ class BaseTestRunner(object): ...@@ -713,15 +715,16 @@ class BaseTestRunner(object):
) )
def _timeout_scalefactor(self, options): def _timeout_scalefactor(self, options):
"""Increases timeout for slow build configurations."""
factor = self.mode_options.timeout_scalefactor factor = self.mode_options.timeout_scalefactor
# Simulators are slow, therefore allow a longer timeout.
if self.build_config.arch in SLOW_ARCHS: if self.build_config.arch in SLOW_ARCHS:
factor *= 4
if self.build_config.lite_mode:
factor *= 2 factor *= 2
# Predictable mode is slower.
if self.build_config.predictable: if self.build_config.predictable:
factor *= 2 factor *= 2
if self.build_config.use_sanitizer:
factor *= 1.5
return factor return factor
......
...@@ -244,13 +244,16 @@ class TestCase(object): ...@@ -244,13 +244,16 @@ class TestCase(object):
timeout = self._test_config.timeout timeout = self._test_config.timeout
if "--stress-opt" in params: if "--stress-opt" in params:
timeout *= 4 timeout *= 4
if "--jitless" in params:
timeout *= 2
if "--no-opt" in params:
timeout *= 2
if "--noenable-vfp3" in params: if "--noenable-vfp3" in params:
timeout *= 2 timeout *= 2
if self._get_timeout_param() == TIMEOUT_LONG: if self._get_timeout_param() == TIMEOUT_LONG:
timeout *= 10 timeout *= 10
if self.is_slow:
# TODO(majeski): make it slow outcome dependent. timeout *= 4
timeout *= 2
return timeout return timeout
def get_shell(self): def get_shell(self):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment