Skip to content

V
V8
Commit e61e0194 authored by Frank Tang's avatar Frank Tang Committed by V8 LUCI CQ
Browse files
Options

[Temporal] Add since/until to Instant 

Also add AOs: GetTemporalUnit, NegateTemporalRoundingMode,
MaximumTemporalDurationRoundingIncrement, GetDifferenceSettings,
DifferenceInstant, DifferenceTemporalInstant

Spec Text:
https://tc39.es/proposal-temporal/#sec-temporal.instant.prototype.since
https://tc39.es/proposal-temporal/#sec-temporal.instant.prototype.until
https://tc39.es/proposal-temporal/#sec-temporal-gettemporalunit
https://tc39.es/proposal-temporal/#sec-temporal-negatetemporalroundingmode
https://tc39.es/proposal-temporal/#sec-temporal-maximumtemporaldurationroundingincrement
https://tc39.es/proposal-temporal/#sec-temporal-getdifferencesettings
https://tc39.es/proposal-temporal/#sec-temporal-differenceinstant
https://tc39.es/proposal-temporal/#sec-temporal-differencetemporalinstant

Bug: v8:11544
Change-Id: Iabcc452304366132b03bb82529159c7553c610b3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3722456
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81502}
parent a63e2ddf
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 392 additions and 67 deletions
src/builtins/builtins-temporal.cc
View file @ e61e0194
......@@ -81,12 +81,6 @@ TO_BE_IMPLEMENTED(TemporalDurationPrototypeRound)
/* Temporal #sec-temporal.duration.prototype.total */
TO_BE_IMPLEMENTED(TemporalDurationPrototypeTotal)
/* Temporal.Instant */
/* Temporal #sec-temporal.instant.prototype.until */
TO_BE_IMPLEMENTED(TemporalInstantPrototypeUntil)
/* Temporal #sec-temporal.instant.prototype.since */
TO_BE_IMPLEMENTED(TemporalInstantPrototypeSince)
/* Temporal.PlainYearMonth */
/* Temporal #sec-temporal.plainyearmonth.prototype.until */
TO_BE_IMPLEMENTED(TemporalPlainYearMonthPrototypeUntil)
......@@ -630,12 +624,14 @@ TEMPORAL_GET_BIGINT_AFTER_DIVID(Instant, EpochMicroseconds, nanoseconds, 1000,
epochMicroseconds)
TEMPORAL_PROTOTYPE_METHOD1(Instant, Add, add)
TEMPORAL_PROTOTYPE_METHOD1(Instant, Round, round)
TEMPORAL_PROTOTYPE_METHOD2(Instant, Since, since)
TEMPORAL_PROTOTYPE_METHOD1(Instant, Subtract, subtract)
TEMPORAL_PROTOTYPE_METHOD0(Instant, ToJSON, toJSON)
TEMPORAL_PROTOTYPE_METHOD2(Instant, ToLocaleString, toLocaleString)
TEMPORAL_PROTOTYPE_METHOD1(Instant, ToString, toString)
TEMPORAL_PROTOTYPE_METHOD1(Instant, ToZonedDateTime, toZonedDateTime)
TEMPORAL_PROTOTYPE_METHOD1(Instant, ToZonedDateTimeISO, toZonedDateTimeISO)
TEMPORAL_PROTOTYPE_METHOD2(Instant, Until, until)
// Calendar
TEMPORAL_CONSTRUCTOR1(Calendar)
......
src/objects/js-temporal-objects.cc
View file @ e61e0194
This diff is collapsed.
src/objects/js-temporal-objects.h
View file @ e61e0194
......@@ -298,6 +298,16 @@ class JSTemporalInstant
Isolate* isolate, Handle<JSTemporalInstant> instant,
Handle<Object> options);
// #sec-temporal.instant.prototype.until
V8_WARN_UNUSED_RESULT static MaybeHandle<JSTemporalDuration> Until(
Isolate* isolate, Handle<JSTemporalInstant> instant, Handle<Object> other,
Handle<Object> options);
// #sec-temporal.instant.prototype.since
V8_WARN_UNUSED_RESULT static MaybeHandle<JSTemporalDuration> Since(
Isolate* isolate, Handle<JSTemporalInstant> instant, Handle<Object> other,
Handle<Object> options);
DECL_PRINTER(JSTemporalInstant)
TQ_OBJECT_CONSTRUCTORS(JSTemporalInstant)
......
test/test262/test262.status
View file @ e61e0194
......@@ -521,27 +521,7 @@
'built-ins/Temporal/Duration/prototype/total/unit-wrong-type': [FAIL],
'built-ins/Temporal/Instant/prototype/round/subclassing-ignored': [FAIL],
'built-ins/Temporal/Instant/prototype/since/argument-zoneddatetime': [FAIL],
'built-ins/Temporal/Instant/prototype/since/branding': [FAIL],
'built-ins/Temporal/Instant/prototype/since/instant-string': [FAIL],
'built-ins/Temporal/Instant/prototype/since/instant-string-multiple-offsets': [FAIL],
'built-ins/Temporal/Instant/prototype/since/largestunit': [FAIL],
'built-ins/Temporal/Instant/prototype/since/largestunit-invalid-string': [FAIL],
'built-ins/Temporal/Instant/prototype/since/largestunit-plurals-accepted': [FAIL],
'built-ins/Temporal/Instant/prototype/since/largestunit-undefined': [FAIL],
'built-ins/Temporal/Instant/prototype/since/largestunit-wrong-type': [FAIL],
'built-ins/Temporal/Instant/prototype/since/options-undefined': [FAIL],
'built-ins/Temporal/Instant/prototype/since/roundingincrement-nan': [FAIL],
'built-ins/Temporal/Instant/prototype/since/roundingincrement-non-integer': [FAIL],
'built-ins/Temporal/Instant/prototype/since/roundingincrement-out-of-range': [FAIL],
'built-ins/Temporal/Instant/prototype/since/roundingincrement-undefined': [FAIL],
'built-ins/Temporal/Instant/prototype/since/roundingincrement-wrong-type': [FAIL],
'built-ins/Temporal/Instant/prototype/since/roundingmode-invalid-string': [FAIL],
'built-ins/Temporal/Instant/prototype/since/roundingmode-undefined': [FAIL],
'built-ins/Temporal/Instant/prototype/since/roundingmode-wrong-type': [FAIL],
'built-ins/Temporal/Instant/prototype/since/smallestunit-invalid-string': [FAIL],
'built-ins/Temporal/Instant/prototype/since/smallestunit-plurals-accepted': [FAIL],
'built-ins/Temporal/Instant/prototype/since/smallestunit-undefined': [FAIL],
'built-ins/Temporal/Instant/prototype/since/smallestunit-wrong-type': [FAIL],
'built-ins/Temporal/Instant/prototype/toString/smallestunit-valid-units': [FAIL],
'built-ins/Temporal/Instant/prototype/toString/timezone': [FAIL],
'built-ins/Temporal/Instant/prototype/toString/timezone-offset': [FAIL],
......@@ -550,26 +530,6 @@
'built-ins/Temporal/Instant/prototype/toZonedDateTimeISO/timezone-string-multiple-offsets': [FAIL],
'built-ins/Temporal/Instant/prototype/toZonedDateTime/timezone-string-multiple-offsets': [FAIL],
'built-ins/Temporal/Instant/prototype/until/argument-zoneddatetime': [FAIL],
'built-ins/Temporal/Instant/prototype/until/branding': [FAIL],
'built-ins/Temporal/Instant/prototype/until/instant-string': [FAIL],
'built-ins/Temporal/Instant/prototype/until/instant-string-multiple-offsets': [FAIL],
'built-ins/Temporal/Instant/prototype/until/largestunit-invalid-string': [FAIL],
'built-ins/Temporal/Instant/prototype/until/largestunit-plurals-accepted': [FAIL],
'built-ins/Temporal/Instant/prototype/until/largestunit-undefined': [FAIL],
'built-ins/Temporal/Instant/prototype/until/largestunit-wrong-type': [FAIL],
'built-ins/Temporal/Instant/prototype/until/options-undefined': [FAIL],
'built-ins/Temporal/Instant/prototype/until/roundingincrement-nan': [FAIL],
'built-ins/Temporal/Instant/prototype/until/roundingincrement-non-integer': [FAIL],
'built-ins/Temporal/Instant/prototype/until/roundingincrement-out-of-range': [FAIL],
'built-ins/Temporal/Instant/prototype/until/roundingincrement-undefined': [FAIL],
'built-ins/Temporal/Instant/prototype/until/roundingincrement-wrong-type': [FAIL],
'built-ins/Temporal/Instant/prototype/until/roundingmode-invalid-string': [FAIL],
'built-ins/Temporal/Instant/prototype/until/roundingmode-undefined': [FAIL],
'built-ins/Temporal/Instant/prototype/until/roundingmode-wrong-type': [FAIL],
'built-ins/Temporal/Instant/prototype/until/smallestunit-invalid-string': [FAIL],
'built-ins/Temporal/Instant/prototype/until/smallestunit-plurals-accepted': [FAIL],
'built-ins/Temporal/Instant/prototype/until/smallestunit-undefined': [FAIL],
'built-ins/Temporal/Instant/prototype/until/smallestunit-wrong-type': [FAIL],
'built-ins/Temporal/Now/zonedDateTimeISO/timezone-string-multiple-offsets': [FAIL],
'built-ins/Temporal/Now/zonedDateTime/timezone-string-multiple-offsets': [FAIL],
'built-ins/Temporal/PlainDate/from/limits': [FAIL],
......@@ -1180,10 +1140,6 @@
'built-ins/Temporal/Duration/prototype/subtract/year-zero': [FAIL],
'built-ins/Temporal/Duration/prototype/total/calendar-possibly-required': [FAIL],
'built-ins/Temporal/Duration/prototype/total/year-zero': [FAIL],
'built-ins/Temporal/Instant/prototype/since/largestunit-smallestunit-mismatch': [FAIL],
'built-ins/Temporal/Instant/prototype/since/year-zero': [FAIL],
'built-ins/Temporal/Instant/prototype/until/largestunit-smallestunit-mismatch': [FAIL],
'built-ins/Temporal/Instant/prototype/until/year-zero': [FAIL],
'built-ins/Temporal/PlainDate/prototype/since/days-in-month': [FAIL],
'built-ins/Temporal/PlainDate/prototype/since/days-in-year': [FAIL],
'built-ins/Temporal/PlainDate/prototype/since/largestunit-undefined': [FAIL],
......@@ -1349,11 +1305,9 @@
'built-ins/Temporal/Duration/prototype/round/roundto-invalid-string': [FAIL],
'built-ins/Temporal/Duration/prototype/subtract/options-wrong-type': [FAIL],
'built-ins/Temporal/Instant/prototype/round/rounding-direction': [FAIL],
'built-ins/Temporal/Instant/prototype/since/options-wrong-type': [FAIL],
'built-ins/Temporal/Instant/prototype/toString/fractionalseconddigits-number': [FAIL],
'built-ins/Temporal/Instant/prototype/toString/rounding-cross-midnight': [FAIL],
'built-ins/Temporal/Instant/prototype/toString/rounding-direction': [FAIL],
'built-ins/Temporal/Instant/prototype/until/options-wrong-type': [FAIL],
'built-ins/Temporal/PlainDate/prototype/since/options-wrong-type': [FAIL],
'built-ins/Temporal/PlainDate/prototype/until/options-wrong-type': [FAIL],
'built-ins/Temporal/PlainDateTime/prototype/round/balance': [FAIL],
......@@ -1472,13 +1426,7 @@
'built-ins/Temporal/Duration/prototype/total/relativeto-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/Duration/prototype/total/relativeto-wrong-type': [FAIL],
'built-ins/Temporal/Duration/prototype/total/timezone-wrong-type': [FAIL],
'built-ins/Temporal/Instant/prototype/since/argument-object-tostring': [FAIL],
'built-ins/Temporal/Instant/prototype/since/argument-wrong-type': [FAIL],
'built-ins/Temporal/Instant/prototype/since/instant-string-sub-minute-offset': [FAIL],
'built-ins/Temporal/Instant/prototype/toZonedDateTime/calendar-number': [FAIL],
'built-ins/Temporal/Instant/prototype/until/argument-object-tostring': [FAIL],
'built-ins/Temporal/Instant/prototype/until/argument-wrong-type': [FAIL],
'built-ins/Temporal/Instant/prototype/until/instant-string-sub-minute-offset': [FAIL],
'built-ins/Temporal/Now/plainDate/calendar-number': [FAIL],
'built-ins/Temporal/Now/plainDateTime/calendar-number': [FAIL],
'built-ins/Temporal/Now/zonedDateTime/calendar-number': [FAIL],
......@@ -1611,14 +1559,8 @@
'built-ins/Temporal/Duration/prototype/total/timezone-string-year-zero': [FAIL],
'built-ins/Temporal/Instant/from/argument-string': [FAIL],
'built-ins/Temporal/Instant/prototype/add/argument-string-negative-fractional-units': [FAIL],
'built-ins/Temporal/Instant/prototype/since/argument-string-invalid': [FAIL],
'built-ins/Temporal/Instant/prototype/since/argument-string-time-separators': [FAIL],
'built-ins/Temporal/Instant/prototype/since/leap-second': [FAIL],
'built-ins/Temporal/Instant/prototype/subtract/argument-string-negative-fractional-units': [FAIL],
'built-ins/Temporal/Instant/prototype/toString/timezone-string-leap-second': [FAIL],
'built-ins/Temporal/Instant/prototype/until/argument-string-invalid': [FAIL],
'built-ins/Temporal/Instant/prototype/until/argument-string-time-separators': [FAIL],
'built-ins/Temporal/Instant/prototype/until/leap-second': [FAIL],
'built-ins/Temporal/PlainDate/prototype/since/argument-leap-second': [FAIL],
'built-ins/Temporal/PlainDate/prototype/since/argument-propertybag-calendar-leap-second': [FAIL],
'built-ins/Temporal/PlainDate/prototype/since/argument-propertybag-calendar-year-zero': [FAIL],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment