remove ID field from StackTraceFrame

Marked GetStackFrameId V8_DEPRECATED

Bug: v8:10566
Change-Id: I2e225eae7d0375cff7b9f79e4c38802265940219
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352475
Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69650}

src/api/api.cc

@@ -10115,9 +10115,8 @@ debug::ConsoleCallArguments::ConsoleCallArguments(
           args.length() > 1 ? args.address_of_first_argument() : nullptr,
           args.length() - 1) {}
 
-int debug::GetStackFrameId(v8::Local<v8::StackFrame> frame) {
-  return Utils::OpenHandle(*frame)->id();
-}
+// Marked V8_DEPRECATED.
+int debug::GetStackFrameId(v8::Local<v8::StackFrame> frame) { return 0; }
 
 v8::Local<v8::StackTrace> debug::GetDetailedStackTrace(
     Isolate* v8_isolate, v8::Local<v8::Object> v8_error) {

src/debug/debug-interface.h

@@ -250,6 +250,7 @@ Local<Function> GetBuiltin(Isolate* isolate, Builtin builtin);
 V8_EXPORT_PRIVATE void SetConsoleDelegate(Isolate* isolate,
                                           ConsoleDelegate* delegate);
 
+V8_DEPRECATED("See http://crbug.com/v8/10566.")
 int GetStackFrameId(v8::Local<v8::StackFrame> frame);
 
 v8::Local<v8::StackTrace> GetDetailedStackTrace(Isolate* isolate,

src/diagnostics/objects-printer.cc

@@ -2205,7 +2205,6 @@ void ScopeInfo::ScopeInfoPrint(std::ostream& os) {  // NOLINT
 void StackTraceFrame::StackTraceFramePrint(std::ostream& os) {  // NOLINT
   PrintHeader(os, "StackTraceFrame");
   os << "\n - frame_index: " << frame_index();
-  os << "\n - id: " << id();
   os << "\n - frame_info: " << Brief(frame_info());
   os << "\n";
 }

src/execution/isolate.cc

@@ -4382,13 +4382,6 @@ void Isolate::CountUsage(v8::Isolate::UseCounterFeature feature) {
 
 int Isolate::GetNextScriptId() { return heap()->NextScriptId(); }
 
-int Isolate::GetNextStackFrameInfoId() {
-  int id = last_stack_frame_info_id();
-  int next_id = id == Smi::kMaxValue ? 0 : (id + 1);
-  set_last_stack_frame_info_id(next_id);
-  return next_id;
-}
-
 // static
 std::string Isolate::GetTurboCfgFileName(Isolate* isolate) {
   if (FLAG_trace_turbo_cfg_file == nullptr) {

src/execution/isolate.h

@@ -443,7 +443,6 @@ using DebugObjectCache = std::vector<Handle<HeapObject>>;
   /* Current code coverage mode */                                             \
   V(debug::CoverageMode, code_coverage_mode, debug::CoverageMode::kBestEffort) \
   V(debug::TypeProfileMode, type_profile_mode, debug::TypeProfileMode::kNone)  \
-  V(int, last_stack_frame_info_id, 0)                                          \
   V(int, last_console_context_id, 0)                                           \
   V(v8_inspector::V8Inspector*, inspector, nullptr)                            \
   V(bool, next_v8_call_is_safe_for_termination, false)                         \
@@ -1311,8 +1310,6 @@ class V8_EXPORT_PRIVATE Isolate final : private HiddenFactory {
 
   int GetNextScriptId();
 
-  int GetNextStackFrameInfoId();
-
 #if V8_SFI_HAS_UNIQUE_ID
   int GetNextUniqueSharedFunctionInfoId() {
     int current_id = next_unique_sfi_id_.load(std::memory_order_relaxed);

src/heap/factory.cc

@@ -3099,7 +3099,6 @@ Handle<StackTraceFrame> Factory::NewStackTraceFrame(
   frame->set_frame_index(index);
   frame->set_frame_info(*undefined_value());
 
-  frame->set_id(isolate()->GetNextStackFrameInfoId());
   return frame;
 }
 

src/objects/stack-frame-info.tq

@@ -37,5 +37,4 @@ extern class StackTraceFrame extends Struct {
   frame_array: FrameArray|Undefined;
   frame_index: Smi;
   frame_info: StackFrameInfo|Undefined;
-  id: Smi;
 }