Commit e4b3f93e authored by ulan's avatar ulan Committed by Commit bot

[heap] Add a flag to disable remembered set verification.

BUG=chromium:720606

Review-Url: https://codereview.chromium.org/2871173006
Cr-Commit-Position: refs/heads/master@{#45252}
parent 33235355
...@@ -700,6 +700,8 @@ DEFINE_BOOL(trace_detached_contexts, false, ...@@ -700,6 +700,8 @@ DEFINE_BOOL(trace_detached_contexts, false,
DEFINE_IMPLICATION(trace_detached_contexts, track_detached_contexts) DEFINE_IMPLICATION(trace_detached_contexts, track_detached_contexts)
#ifdef VERIFY_HEAP #ifdef VERIFY_HEAP
DEFINE_BOOL(verify_heap, false, "verify heap pointers before and after GC") DEFINE_BOOL(verify_heap, false, "verify heap pointers before and after GC")
DEFINE_BOOL(verify_heap_skip_remembered_set, false,
"disable remembered set verification")
#endif #endif
DEFINE_BOOL(move_object_start, true, "enable moving of object starts") DEFINE_BOOL(move_object_start, true, "enable moving of object starts")
DEFINE_BOOL(memory_reducer, true, "use memory reducer") DEFINE_BOOL(memory_reducer, true, "use memory reducer")
......
...@@ -1569,7 +1569,9 @@ void PagedSpace::Verify(ObjectVisitor* visitor) { ...@@ -1569,7 +1569,9 @@ void PagedSpace::Verify(ObjectVisitor* visitor) {
// The object itself should look OK. // The object itself should look OK.
object->ObjectVerify(); object->ObjectVerify();
if (!FLAG_verify_heap_skip_remembered_set) {
heap()->VerifyRememberedSetFor(object); heap()->VerifyRememberedSetFor(object);
}
// All the interior pointers should be contained in the heap. // All the interior pointers should be contained in the heap.
int size = object->Size(); int size = object->Size();
...@@ -3323,7 +3325,9 @@ void LargeObjectSpace::Verify() { ...@@ -3323,7 +3325,9 @@ void LargeObjectSpace::Verify() {
// The object itself should look OK. // The object itself should look OK.
object->ObjectVerify(); object->ObjectVerify();
if (!FLAG_verify_heap_skip_remembered_set) {
heap()->VerifyRememberedSetFor(object); heap()->VerifyRememberedSetFor(object);
}
// Byte arrays and strings don't have interior pointers. // Byte arrays and strings don't have interior pointers.
if (object->IsAbstractCode()) { if (object->IsAbstractCode()) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment