Fix issue 683: change the order of CPU profiler setup actions.

BUG=683

Review URL: http://codereview.chromium.org/1756003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4464 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 9cf54367
...@@ -420,6 +420,10 @@ void CpuProfiler::StartProcessorIfNotStarted() { ...@@ -420,6 +420,10 @@ void CpuProfiler::StartProcessorIfNotStarted() {
generator_ = new ProfileGenerator(profiles_); generator_ = new ProfileGenerator(profiles_);
processor_ = new ProfilerEventsProcessor(generator_); processor_ = new ProfilerEventsProcessor(generator_);
processor_->Start(); processor_->Start();
// Enable stack sampling.
// It is important to have it started prior to logging, see issue 683:
// http://code.google.com/p/v8/issues/detail?id=683
reinterpret_cast<Sampler*>(Logger::ticker_)->Start();
// Enumerate stuff we already have in the heap. // Enumerate stuff we already have in the heap.
if (Heap::HasBeenSetup()) { if (Heap::HasBeenSetup()) {
Logger::LogCodeObjects(); Logger::LogCodeObjects();
...@@ -427,8 +431,6 @@ void CpuProfiler::StartProcessorIfNotStarted() { ...@@ -427,8 +431,6 @@ void CpuProfiler::StartProcessorIfNotStarted() {
Logger::LogFunctionObjects(); Logger::LogFunctionObjects();
Logger::LogAccessorCallbacks(); Logger::LogAccessorCallbacks();
} }
// Enable stack sampling.
reinterpret_cast<Sampler*>(Logger::ticker_)->Start();
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment