Commit e3f40ad2 authored by Alexei Filippov's avatar Alexei Filippov Committed by Commit Bot

[heap profiler] Refactor: do not pass parent_obj argument when not needed.

Change-Id: I13e3a54f91e8fbaf595bebb65f9a0326bbacd3eb
Reviewed-on: https://chromium-review.googlesource.com/c/1244286
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56389}
parent 60b0bea8
This diff is collapsed.
...@@ -381,42 +381,37 @@ class V8HeapExplorer : public HeapEntriesAllocator { ...@@ -381,42 +381,37 @@ class V8HeapExplorer : public HeapEntriesAllocator {
template <typename T> template <typename T>
void ExtractWeakArrayReferences(int header_size, HeapEntry* entry, T* array); void ExtractWeakArrayReferences(int header_size, HeapEntry* entry, T* array);
void ExtractPropertyReferences(JSObject* js_obj, HeapEntry* entry); void ExtractPropertyReferences(JSObject* js_obj, HeapEntry* entry);
void ExtractAccessorPairProperty(JSObject* js_obj, HeapEntry* entry, void ExtractAccessorPairProperty(HeapEntry* entry, Name* key,
Name* key, Object* callback_obj, Object* callback_obj, int field_offset = -1);
int field_offset = -1);
void ExtractElementReferences(JSObject* js_obj, HeapEntry* entry); void ExtractElementReferences(JSObject* js_obj, HeapEntry* entry);
void ExtractInternalReferences(JSObject* js_obj, HeapEntry* entry); void ExtractInternalReferences(JSObject* js_obj, HeapEntry* entry);
bool IsEssentialObject(Object* object); bool IsEssentialObject(Object* object);
bool IsEssentialHiddenReference(Object* parent, int field_offset); bool IsEssentialHiddenReference(Object* parent, int field_offset);
void SetContextReference(HeapObject* parent_obj, HeapEntry* parent_entry, void SetContextReference(HeapEntry* parent_entry, String* reference_name,
String* reference_name, Object* child, Object* child, int field_offset);
int field_offset); void SetNativeBindReference(HeapEntry* parent_entry,
void SetNativeBindReference(HeapObject* parent_obj, HeapEntry* parent_entry,
const char* reference_name, Object* child); const char* reference_name, Object* child);
void SetElementReference(HeapObject* parent_obj, HeapEntry* parent_entry, void SetElementReference(HeapEntry* parent_entry, int index, Object* child);
int index, Object* child); void SetInternalReference(HeapEntry* parent_entry, const char* reference_name,
void SetInternalReference(HeapObject* parent_obj, HeapEntry* parent_entry, Object* child, int field_offset = -1);
const char* reference_name, Object* child, void SetInternalReference(HeapEntry* parent_entry, int index, Object* child,
int field_offset = -1); int field_offset = -1);
void SetInternalReference(HeapObject* parent_obj, HeapEntry* parent_entry,
int index, Object* child, int field_offset = -1);
void SetHiddenReference(HeapObject* parent_obj, HeapEntry* parent_entry, void SetHiddenReference(HeapObject* parent_obj, HeapEntry* parent_entry,
int index, Object* child, int field_offset); int index, Object* child, int field_offset);
void SetWeakReference(HeapObject* parent_obj, HeapEntry* parent_entry, void SetWeakReference(HeapEntry* parent_entry, const char* reference_name,
const char* reference_name, Object* child_obj, Object* child_obj, int field_offset);
void SetWeakReference(HeapEntry* parent_entry, int index, Object* child_obj,
int field_offset); int field_offset);
void SetWeakReference(HeapObject* parent_obj, HeapEntry* parent_entry, void SetPropertyReference(HeapEntry* parent_entry, Name* reference_name,
int index, Object* child_obj, int field_offset); Object* child,
void SetPropertyReference(HeapObject* parent_obj, HeapEntry* parent_entry,
Name* reference_name, Object* child,
const char* name_format_string = nullptr, const char* name_format_string = nullptr,
int field_offset = -1); int field_offset = -1);
void SetDataOrAccessorPropertyReference( void SetDataOrAccessorPropertyReference(
PropertyKind kind, JSObject* parent_obj, HeapEntry* parent_entry, PropertyKind kind, HeapEntry* parent_entry, Name* reference_name,
Name* reference_name, Object* child, Object* child, const char* name_format_string = nullptr,
const char* name_format_string = nullptr, int field_offset = -1); int field_offset = -1);
void SetUserGlobalReference(Object* user_global); void SetUserGlobalReference(Object* user_global);
void SetRootGcRootsReference(); void SetRootGcRootsReference();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment