Commit e3d10614 authored by jgruber's avatar jgruber Committed by Commit bot

Remove GetStackTraceLine

BUG=

Review-Url: https://codereview.chromium.org/2194883002
Cr-Commit-Position: refs/heads/master@{#38215}
parent 6c1d6c9f
......@@ -102,7 +102,6 @@ enum BindingFlags {
V(DERIVED_GET_TRAP_INDEX, JSFunction, derived_get_trap) \
V(ERROR_FUNCTION_INDEX, JSFunction, error_function) \
V(EVAL_ERROR_FUNCTION_INDEX, JSFunction, eval_error_function) \
V(GET_STACK_TRACE_LINE_INDEX, JSFunction, get_stack_trace_line_fun) \
V(GLOBAL_EVAL_FUN_INDEX, JSFunction, global_eval_fun) \
V(MAKE_ERROR_FUNCTION_INDEX, JSFunction, make_error_function) \
V(MAP_DELETE_METHOD_INDEX, JSFunction, map_delete) \
......
......@@ -431,16 +431,26 @@ Handle<String> Execution::GetStackTraceLine(Handle<Object> recv,
Handle<Object> pos,
Handle<Object> is_global) {
Isolate* isolate = fun->GetIsolate();
Handle<Object> args[] = { recv, fun, pos, is_global };
MaybeHandle<Object> maybe_result =
TryCall(isolate, isolate->get_stack_trace_line_fun(),
isolate->factory()->undefined_value(), arraysize(args), args);
Handle<Object> result;
if (!maybe_result.ToHandle(&result) || !result->IsString()) {
Handle<JSFunction> ctor =
handle(isolate->native_context()->callsite_function(), isolate);
Handle<Object> strict_mode = isolate->factory()->ToBoolean(false);
MaybeHandle<Object> maybe_callsite = CallSiteUtils::Construct(
isolate, ctor, ctor, recv, fun, pos, strict_mode);
if (maybe_callsite.is_null()) {
isolate->clear_pending_exception();
return isolate->factory()->empty_string();
}
MaybeHandle<String> maybe_to_string =
CallSiteUtils::ToString(isolate, maybe_callsite.ToHandleChecked());
if (maybe_to_string.is_null()) {
isolate->clear_pending_exception();
return isolate->factory()->empty_string();
}
return Handle<String>::cast(result);
return maybe_to_string.ToHandleChecked();
}
......
......@@ -248,11 +248,6 @@ utils.SetUpLockedPrototype(Script, [
]
);
function GetStackTraceLine(recv, fun, pos, isGlobal) {
return new CallSite(recv, fun, pos, false).toString();
}
// ----------------------------------------------------------------------------
// Error implementation
......@@ -293,7 +288,6 @@ function MakeURIError() {
}
%InstallToContext([
"get_stack_trace_line_fun", GetStackTraceLine,
"make_error_function", MakeGenericError,
"make_range_error", MakeRangeError,
"make_type_error", MakeTypeError,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment