Revert "Remove redundant loads in DoCheckMaps"

This reverts r13200.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/11552017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13206 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 76375de2
...@@ -4945,33 +4945,33 @@ void LCodeGen::DoCheckFunction(LCheckFunction* instr) { ...@@ -4945,33 +4945,33 @@ void LCodeGen::DoCheckFunction(LCheckFunction* instr) {
} }
void LCodeGen::DoCheckMapCommon(Register map_reg, void LCodeGen::DoCheckMapCommon(Register reg,
Register scratch,
Handle<Map> map, Handle<Map> map,
CompareMapMode mode, CompareMapMode mode,
LEnvironment* env) { LEnvironment* env) {
Label success; Label success;
__ CompareMap(map_reg, map, &success, mode); __ CompareMap(reg, scratch, map, &success, mode);
DeoptimizeIf(ne, env); DeoptimizeIf(ne, env);
__ bind(&success); __ bind(&success);
} }
void LCodeGen::DoCheckMaps(LCheckMaps* instr) { void LCodeGen::DoCheckMaps(LCheckMaps* instr) {
Register map_reg = scratch0(); Register scratch = scratch0();
LOperand* input = instr->value(); LOperand* input = instr->value();
ASSERT(input->IsRegister()); ASSERT(input->IsRegister());
Register reg = ToRegister(input); Register reg = ToRegister(input);
Label success; Label success;
SmallMapList* map_set = instr->hydrogen()->map_set(); SmallMapList* map_set = instr->hydrogen()->map_set();
__ ldr(map_reg, FieldMemOperand(reg, HeapObject::kMapOffset));
for (int i = 0; i < map_set->length() - 1; i++) { for (int i = 0; i < map_set->length() - 1; i++) {
Handle<Map> map = map_set->at(i); Handle<Map> map = map_set->at(i);
__ CompareMap(map_reg, map, &success, REQUIRE_EXACT_MAP); __ CompareMap(reg, scratch, map, &success, REQUIRE_EXACT_MAP);
__ b(eq, &success); __ b(eq, &success);
} }
Handle<Map> map = map_set->last(); Handle<Map> map = map_set->last();
DoCheckMapCommon(map_reg, map, REQUIRE_EXACT_MAP, instr->environment()); DoCheckMapCommon(reg, scratch, map, REQUIRE_EXACT_MAP, instr->environment());
__ bind(&success); __ bind(&success);
} }
...@@ -5030,29 +5030,28 @@ void LCodeGen::DoClampTToUint8(LClampTToUint8* instr) { ...@@ -5030,29 +5030,28 @@ void LCodeGen::DoClampTToUint8(LClampTToUint8* instr) {
void LCodeGen::DoCheckPrototypeMaps(LCheckPrototypeMaps* instr) { void LCodeGen::DoCheckPrototypeMaps(LCheckPrototypeMaps* instr) {
ASSERT(instr->temp()->Equals(instr->result())); ASSERT(instr->temp()->Equals(instr->result()));
Register prototype_reg = ToRegister(instr->temp()); Register temp1 = ToRegister(instr->temp());
Register map_reg = ToRegister(instr->temp2()); Register temp2 = ToRegister(instr->temp2());
Handle<JSObject> holder = instr->holder(); Handle<JSObject> holder = instr->holder();
Handle<JSObject> current_prototype = instr->prototype(); Handle<JSObject> current_prototype = instr->prototype();
// Load prototype object. // Load prototype object.
__ LoadHeapObject(prototype_reg, current_prototype); __ LoadHeapObject(temp1, current_prototype);
// Check prototype maps up to the holder. // Check prototype maps up to the holder.
while (!current_prototype.is_identical_to(holder)) { while (!current_prototype.is_identical_to(holder)) {
__ ldr(map_reg, FieldMemOperand(prototype_reg, HeapObject::kMapOffset)); DoCheckMapCommon(temp1, temp2,
DoCheckMapCommon(map_reg,
Handle<Map>(current_prototype->map()), Handle<Map>(current_prototype->map()),
ALLOW_ELEMENT_TRANSITION_MAPS, instr->environment()); ALLOW_ELEMENT_TRANSITION_MAPS, instr->environment());
current_prototype = current_prototype =
Handle<JSObject>(JSObject::cast(current_prototype->GetPrototype())); Handle<JSObject>(JSObject::cast(current_prototype->GetPrototype()));
// Load next prototype object. // Load next prototype object.
__ LoadHeapObject(prototype_reg, current_prototype); __ LoadHeapObject(temp1, current_prototype);
} }
// Check the holder map. // Check the holder map.
DoCheckMapCommon(map_reg, DoCheckMapCommon(temp1, temp2,
Handle<Map>(current_prototype->map()), Handle<Map>(current_prototype->map()),
ALLOW_ELEMENT_TRANSITION_MAPS, instr->environment()); ALLOW_ELEMENT_TRANSITION_MAPS, instr->environment());
} }
......
...@@ -131,7 +131,7 @@ class LCodeGen BASE_EMBEDDED { ...@@ -131,7 +131,7 @@ class LCodeGen BASE_EMBEDDED {
void DoDeferredInstanceOfKnownGlobal(LInstanceOfKnownGlobal* instr, void DoDeferredInstanceOfKnownGlobal(LInstanceOfKnownGlobal* instr,
Label* map_check); Label* map_check);
void DoCheckMapCommon(Register map_reg, Handle<Map> map, void DoCheckMapCommon(Register reg, Register scratch, Handle<Map> map,
CompareMapMode mode, LEnvironment* env); CompareMapMode mode, LEnvironment* env);
// Parallel move support. // Parallel move support.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment