Commit e3014ad8 authored by mstarzinger's avatar mstarzinger Committed by Commit bot

[interpreter] Fix BytecodeGraphBuilder for disabled deopt.

This ensures that the BytecodeGraphBuilder can generate correct graphs
even when deoptimization has not been enabled. This configuration is not
enabled in production, and we might eventually decide to deprecate it
for good. Until then, this is a quick fix.

R=jarin@chromium.org
TEST=cctest/test-pipeline

Review URL: https://codereview.chromium.org/1640683002

Cr-Commit-Position: refs/heads/master@{#33545}
parent 95bec7e7
...@@ -363,6 +363,7 @@ bool BytecodeGraphBuilder::Environment::StateValuesAreUpToDate( ...@@ -363,6 +363,7 @@ bool BytecodeGraphBuilder::Environment::StateValuesAreUpToDate(
bool BytecodeGraphBuilder::Environment::StateValuesAreUpToDate( bool BytecodeGraphBuilder::Environment::StateValuesAreUpToDate(
int output_poke_offset, int output_poke_count) { int output_poke_offset, int output_poke_count) {
if (!builder()->info()->is_deoptimization_enabled()) return true;
// Poke offset is relative to the top of the stack (i.e., the accumulator). // Poke offset is relative to the top of the stack (i.e., the accumulator).
int output_poke_start = accumulator_base() - output_poke_offset; int output_poke_start = accumulator_base() - output_poke_offset;
int output_poke_end = output_poke_start + output_poke_count; int output_poke_end = output_poke_start + output_poke_count;
......
...@@ -554,8 +554,6 @@ ...@@ -554,8 +554,6 @@
'test-parsing/StrongModeFreeVariablesDeclaredByLanguage': [SKIP], 'test-parsing/StrongModeFreeVariablesDeclaredByLanguage': [SKIP],
'test-parsing/StrongModeFreeVariablesDeclaredByPreviousScript': [SKIP], 'test-parsing/StrongModeFreeVariablesDeclaredByPreviousScript': [SKIP],
'test-parsing/StrongModeFreeVariablesDeclaredInGlobalPrototype': [SKIP], 'test-parsing/StrongModeFreeVariablesDeclaredInGlobalPrototype': [SKIP],
'test-pipeline/PipelineGeneric': [SKIP],
'test-pipeline/PipelineTyped': [SKIP],
'test-profile-generator/BailoutReason': [SKIP], 'test-profile-generator/BailoutReason': [SKIP],
'test-profile-generator/LineNumber': [SKIP], 'test-profile-generator/LineNumber': [SKIP],
'test-profile-generator/ProfileNodeScriptId': [SKIP], 'test-profile-generator/ProfileNodeScriptId': [SKIP],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment