[nci] Fix DCHECK(function->is_compiled()) in CompileOptimized

For NCI compilation tasks, we don't actually install the generated
Code object on the function. In that case, we cannot make assertions
about function state.

Bug: v8:8888,chromium:1146013
Change-Id: Ia2342c52e565ccb1f6b5b09dda5e998b3fd3eb3a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2532297
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71140}

src/codegen/compiler.cc

@@ -1938,7 +1938,8 @@ bool Compiler::CompileOptimized(Handle<JSFunction> function,
   // Check postconditions on success.
   DCHECK(!isolate->has_pending_exception());
   DCHECK(function->shared().is_compiled());
-  DCHECK(function->is_compiled());
+  DCHECK(IsForNativeContextIndependentCachingOnly(code_kind) ||
+         function->is_compiled());
   if (UsesOptimizationMarker(code_kind)) {
     DCHECK_IMPLIES(function->HasOptimizationMarker(),
                    function->IsInOptimizationQueue());

test/mjsunit/regress/regress-1146013.js

+// Copyright 2020 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// Flags: --no-use-ic --interrupt-budget=1000
+
+try {
+} catch (e) {}
+class __c_0 extends class {} {
+  constructor() {
+    let __v_18 = () => {
+      for (let __v_19 = 0; __v_19 < 10; __v_19++) {
+        this.x;
+      }
+    };
+    super();
+    __v_18();
+  }
+}
+for (let __v_21 = 0; __v_21 < 10000; __v_21++) {
+  new __c_0();
+}