Commit e027a3ee authored by Igor Sheludko's avatar Igor Sheludko Committed by Commit Bot

[runtime] Cleanup native methods creation in debug/debug.js and debug/mirrors.js.

This CL replaces usages of utils.InstallFunctions and utils.InstallGetter()
with utils.InstallConstants(). Since these methods are not exposed to the user it
doesn't matter if we add them with DONT_ENUM attributes or not.

This CL is one of a series of cleanup CL which are the preliminary steps for
improving function closures creation.

Bug: v8:6459
Change-Id: I41708741f1cc013e4f4c37f1c7a73c1333deca7d
Reviewed-on: https://chromium-review.googlesource.com/548137
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46288}
parent 4e9e8145
...@@ -1000,7 +1000,7 @@ utils.InstallConstants(global, [ ...@@ -1000,7 +1000,7 @@ utils.InstallConstants(global, [
]); ]);
// Functions needed by the debugger runtime. // Functions needed by the debugger runtime.
utils.InstallFunctions(utils, DONT_ENUM, [ utils.InstallConstants(utils, [
"MakeExecutionState", MakeExecutionState, "MakeExecutionState", MakeExecutionState,
"MakeExceptionEvent", MakeExceptionEvent, "MakeExceptionEvent", MakeExceptionEvent,
"MakeBreakEvent", MakeBreakEvent, "MakeBreakEvent", MakeBreakEvent,
......
...@@ -2364,11 +2364,8 @@ ContextMirror.prototype.data = function() { ...@@ -2364,11 +2364,8 @@ ContextMirror.prototype.data = function() {
// ---------------------------------------------------------------------------- // ----------------------------------------------------------------------------
// Exports // Exports
utils.InstallFunctions(global, DONT_ENUM, [
"MakeMirror", MakeMirror,
]);
utils.InstallConstants(global, [ utils.InstallConstants(global, [
"MakeMirror", MakeMirror,
"ScopeType", ScopeType, "ScopeType", ScopeType,
"PropertyType", PropertyType, "PropertyType", PropertyType,
"PropertyAttribute", PropertyAttribute, "PropertyAttribute", PropertyAttribute,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment