Commit df80cf0c authored by tebbi's avatar tebbi Committed by Commit bot

Revert of [turbofan] reenable: extend escape analysis to reduce CheckMaps...

Revert of [turbofan] reenable: extend escape analysis to reduce CheckMaps (patchset #1 id:1 of https://codereview.chromium.org/2803643004/ )

Reason for revert:
canary crashes

Original issue's description:
> [turbofan] reenable: extend escape analysis to reduce CheckMaps
>
> R=bmeurer@chromium.org
>
> Review-Url: https://codereview.chromium.org/2803643004
> Cr-Commit-Position: refs/heads/master@{#44461}
> Committed: https://chromium.googlesource.com/v8/v8/+/25aff3448eb1813702d098361437a7e88256a1c1

TBR=bmeurer@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2811693002
Cr-Commit-Position: refs/heads/master@{#44514}
parent 930174c2
...@@ -1529,6 +1529,7 @@ void EscapeAnalysis::ProcessCheckMaps(Node* node) { ...@@ -1529,6 +1529,7 @@ void EscapeAnalysis::ProcessCheckMaps(Node* node) {
DCHECK_EQ(node->opcode(), IrOpcode::kCheckMaps); DCHECK_EQ(node->opcode(), IrOpcode::kCheckMaps);
ForwardVirtualState(node); ForwardVirtualState(node);
Node* checked = ResolveReplacement(NodeProperties::GetValueInput(node, 0)); Node* checked = ResolveReplacement(NodeProperties::GetValueInput(node, 0));
if (FLAG_turbo_experimental) {
VirtualState* state = virtual_states_[node->id()]; VirtualState* state = virtual_states_[node->id()];
if (VirtualObject* object = GetVirtualObject(state, checked)) { if (VirtualObject* object = GetVirtualObject(state, checked)) {
if (!object->IsTracked()) { if (!object->IsTracked()) {
...@@ -1551,11 +1552,13 @@ void EscapeAnalysis::ProcessCheckMaps(Node* node) { ...@@ -1551,11 +1552,13 @@ void EscapeAnalysis::ProcessCheckMaps(Node* node) {
if (value->opcode() == IrOpcode::kHeapConstant && if (value->opcode() == IrOpcode::kHeapConstant &&
params.maps().contains(ZoneHandleSet<Map>( params.maps().contains(ZoneHandleSet<Map>(
Handle<Map>::cast(OpParameter<Handle<HeapObject>>(value))))) { Handle<Map>::cast(OpParameter<Handle<HeapObject>>(value))))) {
TRACE("CheckMaps #%i seems to be redundant (until now).\n", node->id()); TRACE("CheckMaps #%i seems to be redundant (until now).\n",
node->id());
return; return;
} }
} }
} }
}
if (status_analysis_->SetEscaped(node)) { if (status_analysis_->SetEscaped(node)) {
TRACE("Setting #%d (%s) to escaped (checking #%i)\n", node->id(), TRACE("Setting #%d (%s) to escaped (checking #%i)\n", node->id(),
node->op()->mnemonic(), checked->id()); node->op()->mnemonic(), checked->id());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment