Commit df748fc0 authored by Georgia Kouveli's avatar Georgia Kouveli Committed by Commit Bot

[arm64] Add missing calls to `Unreachable`.

Change-Id: I15956f50e6c02d7c26d2810a3217d2d22eb71f5c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752871Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com>
Cr-Commit-Position: refs/heads/master@{#73351}
parent ef839bbd
...@@ -409,6 +409,7 @@ void Builtins::Generate_ConstructedNonConstructable(MacroAssembler* masm) { ...@@ -409,6 +409,7 @@ void Builtins::Generate_ConstructedNonConstructable(MacroAssembler* masm) {
FrameScope scope(masm, StackFrame::INTERNAL); FrameScope scope(masm, StackFrame::INTERNAL);
__ PushArgument(x1); __ PushArgument(x1);
__ CallRuntime(Runtime::kThrowConstructedNonConstructable); __ CallRuntime(Runtime::kThrowConstructedNonConstructable);
__ Unreachable();
} }
// TODO(v8:11429): Add a path for "not_compiled" and unify the two uses under // TODO(v8:11429): Add a path for "not_compiled" and unify the two uses under
...@@ -2456,6 +2457,7 @@ void Builtins::Generate_CallOrConstructForwardVarargs(MacroAssembler* masm, ...@@ -2456,6 +2457,7 @@ void Builtins::Generate_CallOrConstructForwardVarargs(MacroAssembler* masm,
__ EnterFrame(StackFrame::INTERNAL); __ EnterFrame(StackFrame::INTERNAL);
__ PushArgument(x3); __ PushArgument(x3);
__ CallRuntime(Runtime::kThrowNotConstructor); __ CallRuntime(Runtime::kThrowNotConstructor);
__ Unreachable();
} }
__ Bind(&new_target_constructor); __ Bind(&new_target_constructor);
} }
...@@ -2594,6 +2596,7 @@ void Builtins::Generate_CallFunction(MacroAssembler* masm, ...@@ -2594,6 +2596,7 @@ void Builtins::Generate_CallFunction(MacroAssembler* masm,
FrameScope frame(masm, StackFrame::INTERNAL); FrameScope frame(masm, StackFrame::INTERNAL);
__ PushArgument(x1); __ PushArgument(x1);
__ CallRuntime(Runtime::kThrowConstructorNonCallableError); __ CallRuntime(Runtime::kThrowConstructorNonCallableError);
__ Unreachable();
} }
} }
...@@ -2793,6 +2796,7 @@ void Builtins::Generate_Call(MacroAssembler* masm, ConvertReceiverMode mode) { ...@@ -2793,6 +2796,7 @@ void Builtins::Generate_Call(MacroAssembler* masm, ConvertReceiverMode mode) {
FrameScope scope(masm, StackFrame::INTERNAL); FrameScope scope(masm, StackFrame::INTERNAL);
__ PushArgument(x1); __ PushArgument(x1);
__ CallRuntime(Runtime::kThrowCalledNonCallable); __ CallRuntime(Runtime::kThrowCalledNonCallable);
__ Unreachable();
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment