Commit df723c28 authored by Samuel Groß's avatar Samuel Groß Committed by V8 LUCI CQ

Disable wasm/multiple-code-spaces test when TSAN is enabled

TSAN may cause the sandbox to fail to obtain enough virtual address
space during initialization, thereby causing it to fall back to a
smaller backing reservation. This combined with the very inefficient
ArrayBufferAllocator that is used in standalone v8 builds when the
sandbox is enabled may cause some tests to run out-of-memory earlier
than they otherwise would. For now we just disable these tests on TSAN
builds, but should be able to re-enable them once we have a better
ArrayBufferAllocator on standalone v8 builds.

Bug: v8:13009, chromium:1340224
Change-Id: I93e46e05d47a8850788504c10a6498067400128a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3738740Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Samuel Groß <saelo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81490}
parent f76486e6
......@@ -697,8 +697,9 @@
# Skip tests that require a large amount of virtual address space (inside the
# sandbox if that is enabled) if tsan is enabled.
'wasm/many-memories': [SKIP],
'regress/wasm/regress-1010272': [SKIP],
'wasm/many-memories': [SKIP],
'wasm/multiple-code-spaces': [SKIP],
}], # 'tsan == True'
##############################################################################
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment