Commit df481cd6 authored by Clemens Backes's avatar Clemens Backes Committed by Commit Bot

[devtools] Show wasm-to-js frames in profiling

Currently, we show wasm frames, js frames, and js-to-wasm frames (the
latter two are identified as "OPTIMIZED"). This CL makes us also show
wasm-to-js frames in CPU profiling.

R=petermarshall@chromium.org

Bug: chromium:1029470
Change-Id: I2d09f73e7d7e62867554f2a95dc8ad4500a2cde1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948706Reviewed-by: 's avatarPeter Marshall <petermarshall@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65313}
parent e76d29b3
......@@ -455,7 +455,10 @@ void SafeStackFrameIterator::Advance() {
last_callback_scope = external_callback_scope_;
external_callback_scope_ = external_callback_scope_->previous();
}
if (frame_->is_java_script() || frame_->is_wasm()) break;
if (frame_->is_java_script() || frame_->is_wasm() ||
frame_->is_wasm_to_js()) {
break;
}
if (frame_->is_exit() || frame_->is_builtin_exit()) {
// Some of the EXIT frames may have ExternalCallbackScope allocated on
// top of them. In that case the scope corresponds to the first EXIT
......
......@@ -210,6 +210,7 @@ class StackFrame {
Type type = this->type();
return type == WASM_COMPILED || type == WASM_INTERPRETER_ENTRY;
}
bool is_wasm_to_js() const { return type() == WASM_TO_JS; }
// Accessors.
Address sp() const { return state_.sp; }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment