Commit df18e841 authored by Andreas Haas's avatar Andreas Haas Committed by Commit Bot

[wasm] Create HandleScope in OnFinishedStream

{AsyncCompileJob::FinishCompile} assumes that it is called within a
{HandleScope}. This was not the case when it was called at the end of
streaming compilation.

R=clemensh@chromium.org

Bug: chromium:860637
Change-Id: I74508e6cdfc145efb9adc76176abce1ca5713515
Reviewed-on: https://chromium-review.googlesource.com/1172357Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55086}
parent 4ed25229
......@@ -2697,6 +2697,7 @@ void AsyncStreamingProcessor::OnFinishedStream(OwnedVector<uint8_t> bytes) {
// is no code section.
job_->DoSync<AsyncCompileJob::PrepareAndStartCompile>(true);
} else {
HandleScope scope(job_->isolate_);
job_->FinishCompile();
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment