Commit dea0d747 authored by brucedawson's avatar brucedawson Committed by Commit bot

Suppress compiler and linker warnings in v8 test binaries

VC++ complains about truncation of integer constants despite use of
static_cast. This isn't very helpful as it gives no way of suppressing
the warning in code, so this change suppresses it on the command line.

Additionally, the linker complains about importing of locally defined
functions in component builds. Until this is fixed the warnings should
be suppressed.

NOTRY=true

Review-Url: https://codereview.chromium.org/2028353004
Cr-Commit-Position: refs/heads/master@{#36695}
parent 928dd329
...@@ -316,6 +316,18 @@ executable("cctest") { ...@@ -316,6 +316,18 @@ executable("cctest") {
} else { } else {
deps += [ "../..:v8" ] deps += [ "../..:v8" ]
} }
if (is_win) {
# This warning is benignly triggered by the U16 and U32 macros in
# bytecode-utils.h.
# C4309: 'static_cast': truncation of constant value
cflags = [ "/wd4309" ]
# Suppress warnings about importing locally defined symbols.
if (is_component_build) {
ldflags = [ "/ignore:4049", "/ignore:4217" ]
}
}
} }
action("resources") { action("resources") {
......
...@@ -165,4 +165,16 @@ executable("unittests") { ...@@ -165,4 +165,16 @@ executable("unittests") {
} else { } else {
deps += [ "../..:v8" ] deps += [ "../..:v8" ]
} }
if (is_win) {
# This warning is benignly triggered by the U16 and U32 macros in
# bytecode-utils.h.
# C4309: 'static_cast': truncation of constant value
cflags = [ "/wd4309" ]
# Suppress warnings about importing locally defined symbols.
if (is_component_build) {
ldflags = [ "/ignore:4049", "/ignore:4217" ]
}
}
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment