Commit de2c0a3b authored by Georg Neis's avatar Georg Neis Committed by Commit Bot

[turbofan] Turn some DCHECKs into CHECKs in Schedule methods

Bug: chromium:1076708
Change-Id: I7f065791310606e11fe89936a36f0fe7cb0d38e7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182639
Auto-Submit: Georg Neis <neis@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67576}
parent ae2a8ac4
...@@ -218,7 +218,7 @@ void Schedule::AddNode(BasicBlock* block, Node* node) { ...@@ -218,7 +218,7 @@ void Schedule::AddNode(BasicBlock* block, Node* node) {
} }
void Schedule::AddGoto(BasicBlock* block, BasicBlock* succ) { void Schedule::AddGoto(BasicBlock* block, BasicBlock* succ) {
DCHECK_EQ(BasicBlock::kNone, block->control()); CHECK_EQ(BasicBlock::kNone, block->control());
block->set_control(BasicBlock::kGoto); block->set_control(BasicBlock::kGoto);
AddSuccessor(block, succ); AddSuccessor(block, succ);
} }
...@@ -243,7 +243,7 @@ bool IsPotentiallyThrowingCall(IrOpcode::Value opcode) { ...@@ -243,7 +243,7 @@ bool IsPotentiallyThrowingCall(IrOpcode::Value opcode) {
void Schedule::AddCall(BasicBlock* block, Node* call, BasicBlock* success_block, void Schedule::AddCall(BasicBlock* block, Node* call, BasicBlock* success_block,
BasicBlock* exception_block) { BasicBlock* exception_block) {
DCHECK_EQ(BasicBlock::kNone, block->control()); CHECK_EQ(BasicBlock::kNone, block->control());
DCHECK(IsPotentiallyThrowingCall(call->opcode())); DCHECK(IsPotentiallyThrowingCall(call->opcode()));
block->set_control(BasicBlock::kCall); block->set_control(BasicBlock::kCall);
AddSuccessor(block, success_block); AddSuccessor(block, success_block);
...@@ -253,7 +253,7 @@ void Schedule::AddCall(BasicBlock* block, Node* call, BasicBlock* success_block, ...@@ -253,7 +253,7 @@ void Schedule::AddCall(BasicBlock* block, Node* call, BasicBlock* success_block,
void Schedule::AddBranch(BasicBlock* block, Node* branch, BasicBlock* tblock, void Schedule::AddBranch(BasicBlock* block, Node* branch, BasicBlock* tblock,
BasicBlock* fblock) { BasicBlock* fblock) {
DCHECK_EQ(BasicBlock::kNone, block->control()); CHECK_EQ(BasicBlock::kNone, block->control());
DCHECK_EQ(IrOpcode::kBranch, branch->opcode()); DCHECK_EQ(IrOpcode::kBranch, branch->opcode());
block->set_control(BasicBlock::kBranch); block->set_control(BasicBlock::kBranch);
AddSuccessor(block, tblock); AddSuccessor(block, tblock);
...@@ -263,7 +263,7 @@ void Schedule::AddBranch(BasicBlock* block, Node* branch, BasicBlock* tblock, ...@@ -263,7 +263,7 @@ void Schedule::AddBranch(BasicBlock* block, Node* branch, BasicBlock* tblock,
void Schedule::AddSwitch(BasicBlock* block, Node* sw, BasicBlock** succ_blocks, void Schedule::AddSwitch(BasicBlock* block, Node* sw, BasicBlock** succ_blocks,
size_t succ_count) { size_t succ_count) {
DCHECK_EQ(BasicBlock::kNone, block->control()); CHECK_EQ(BasicBlock::kNone, block->control());
DCHECK_EQ(IrOpcode::kSwitch, sw->opcode()); DCHECK_EQ(IrOpcode::kSwitch, sw->opcode());
block->set_control(BasicBlock::kSwitch); block->set_control(BasicBlock::kSwitch);
for (size_t index = 0; index < succ_count; ++index) { for (size_t index = 0; index < succ_count; ++index) {
...@@ -273,28 +273,28 @@ void Schedule::AddSwitch(BasicBlock* block, Node* sw, BasicBlock** succ_blocks, ...@@ -273,28 +273,28 @@ void Schedule::AddSwitch(BasicBlock* block, Node* sw, BasicBlock** succ_blocks,
} }
void Schedule::AddTailCall(BasicBlock* block, Node* input) { void Schedule::AddTailCall(BasicBlock* block, Node* input) {
DCHECK_EQ(BasicBlock::kNone, block->control()); CHECK_EQ(BasicBlock::kNone, block->control());
block->set_control(BasicBlock::kTailCall); block->set_control(BasicBlock::kTailCall);
SetControlInput(block, input); SetControlInput(block, input);
if (block != end()) AddSuccessor(block, end()); if (block != end()) AddSuccessor(block, end());
} }
void Schedule::AddReturn(BasicBlock* block, Node* input) { void Schedule::AddReturn(BasicBlock* block, Node* input) {
DCHECK_EQ(BasicBlock::kNone, block->control()); CHECK_EQ(BasicBlock::kNone, block->control());
block->set_control(BasicBlock::kReturn); block->set_control(BasicBlock::kReturn);
SetControlInput(block, input); SetControlInput(block, input);
if (block != end()) AddSuccessor(block, end()); if (block != end()) AddSuccessor(block, end());
} }
void Schedule::AddDeoptimize(BasicBlock* block, Node* input) { void Schedule::AddDeoptimize(BasicBlock* block, Node* input) {
DCHECK_EQ(BasicBlock::kNone, block->control()); CHECK_EQ(BasicBlock::kNone, block->control());
block->set_control(BasicBlock::kDeoptimize); block->set_control(BasicBlock::kDeoptimize);
SetControlInput(block, input); SetControlInput(block, input);
if (block != end()) AddSuccessor(block, end()); if (block != end()) AddSuccessor(block, end());
} }
void Schedule::AddThrow(BasicBlock* block, Node* input) { void Schedule::AddThrow(BasicBlock* block, Node* input) {
DCHECK_EQ(BasicBlock::kNone, block->control()); CHECK_EQ(BasicBlock::kNone, block->control());
block->set_control(BasicBlock::kThrow); block->set_control(BasicBlock::kThrow);
SetControlInput(block, input); SetControlInput(block, input);
if (block != end()) AddSuccessor(block, end()); if (block != end()) AddSuccessor(block, end());
...@@ -302,8 +302,8 @@ void Schedule::AddThrow(BasicBlock* block, Node* input) { ...@@ -302,8 +302,8 @@ void Schedule::AddThrow(BasicBlock* block, Node* input) {
void Schedule::InsertBranch(BasicBlock* block, BasicBlock* end, Node* branch, void Schedule::InsertBranch(BasicBlock* block, BasicBlock* end, Node* branch,
BasicBlock* tblock, BasicBlock* fblock) { BasicBlock* tblock, BasicBlock* fblock) {
DCHECK_NE(BasicBlock::kNone, block->control()); CHECK_NE(BasicBlock::kNone, block->control());
DCHECK_EQ(BasicBlock::kNone, end->control()); CHECK_EQ(BasicBlock::kNone, end->control());
end->set_control(block->control()); end->set_control(block->control());
block->set_control(BasicBlock::kBranch); block->set_control(BasicBlock::kBranch);
MoveSuccessors(block, end); MoveSuccessors(block, end);
...@@ -317,8 +317,8 @@ void Schedule::InsertBranch(BasicBlock* block, BasicBlock* end, Node* branch, ...@@ -317,8 +317,8 @@ void Schedule::InsertBranch(BasicBlock* block, BasicBlock* end, Node* branch,
void Schedule::InsertSwitch(BasicBlock* block, BasicBlock* end, Node* sw, void Schedule::InsertSwitch(BasicBlock* block, BasicBlock* end, Node* sw,
BasicBlock** succ_blocks, size_t succ_count) { BasicBlock** succ_blocks, size_t succ_count) {
DCHECK_NE(BasicBlock::kNone, block->control()); CHECK_NE(BasicBlock::kNone, block->control());
DCHECK_EQ(BasicBlock::kNone, end->control()); CHECK_EQ(BasicBlock::kNone, end->control());
end->set_control(block->control()); end->set_control(block->control());
block->set_control(BasicBlock::kSwitch); block->set_control(BasicBlock::kSwitch);
MoveSuccessors(block, end); MoveSuccessors(block, end);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment