Commit dcf881de authored by Clemens Hammacher's avatar Clemens Hammacher Committed by Commit Bot

Remove redundant {Handle<T>::location()} definition

Since {Handle<T>::location()} just returns the value of
{HandleBase::location()}, we can just publicly expose the latter and
save some compile time and object file size.

R=jkummerow@chromium.org

Bug: v8:9183
Change-Id: I9cddba2c9f8b097c26cf1a4e7dbfbe72b03d79c2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624211
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61737}
parent b05ab0af
......@@ -57,7 +57,6 @@ class HandleBase {
// used for hashing handles; do not ever try to dereference it.
V8_INLINE Address address() const { return bit_cast<Address>(location_); }
protected:
// Returns the address to where the raw pointer is stored.
V8_INLINE Address* location() const {
SLOW_DCHECK(location_ == nullptr ||
......@@ -65,6 +64,7 @@ class HandleBase {
return location_;
}
protected:
enum DereferenceCheckMode { INCLUDE_DEFERRED_CHECK, NO_DEFERRED_CHECK };
#ifdef DEBUG
bool V8_EXPORT_PRIVATE IsDereferenceAllowed(DereferenceCheckMode mode) const;
......@@ -139,9 +139,6 @@ class Handle final : public HandleBase {
return T::unchecked_cast(Object(*location()));
}
// Returns the address to where the raw pointer is stored.
V8_INLINE Address* location() const { return HandleBase::location(); }
template <typename S>
inline static const Handle<T> cast(Handle<S> that);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment