Commit dbc19aff authored by Ng Zhi An's avatar Ng Zhi An Committed by Commit Bot

[clang-tidy] Make deleted member functions public

Making them private was a way to hide the functions, we can
explicitly delete them, which give a better compilation error message as
well.

Also see: https://stackoverflow.com/q/55205874

Bug: v8:10488
Change-Id: I3d3227c3a87ee4de983b0d4a52f46203729b99f2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233983Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68308}
parent 25cca476
...@@ -528,6 +528,7 @@ class PostponeInterruptsScope { ...@@ -528,6 +528,7 @@ class PostponeInterruptsScope {
class WeakMap : public v8::Object { class WeakMap : public v8::Object {
public: public:
WeakMap() = delete;
V8_EXPORT_PRIVATE V8_WARN_UNUSED_RESULT v8::MaybeLocal<v8::Value> Get( V8_EXPORT_PRIVATE V8_WARN_UNUSED_RESULT v8::MaybeLocal<v8::Value> Get(
v8::Local<v8::Context> context, v8::Local<v8::Value> key); v8::Local<v8::Context> context, v8::Local<v8::Value> key);
V8_EXPORT_PRIVATE V8_WARN_UNUSED_RESULT v8::MaybeLocal<WeakMap> Set( V8_EXPORT_PRIVATE V8_WARN_UNUSED_RESULT v8::MaybeLocal<WeakMap> Set(
...@@ -536,9 +537,6 @@ class WeakMap : public v8::Object { ...@@ -536,9 +537,6 @@ class WeakMap : public v8::Object {
V8_EXPORT_PRIVATE static Local<WeakMap> New(v8::Isolate* isolate); V8_EXPORT_PRIVATE static Local<WeakMap> New(v8::Isolate* isolate);
V8_INLINE static WeakMap* Cast(Value* obj); V8_INLINE static WeakMap* Cast(Value* obj);
private:
WeakMap();
}; };
/** /**
...@@ -549,6 +547,7 @@ class WeakMap : public v8::Object { ...@@ -549,6 +547,7 @@ class WeakMap : public v8::Object {
*/ */
class V8_EXPORT_PRIVATE AccessorPair : public v8::Value { class V8_EXPORT_PRIVATE AccessorPair : public v8::Value {
public: public:
AccessorPair() = delete;
v8::Local<v8::Value> getter(); v8::Local<v8::Value> getter();
v8::Local<v8::Value> setter(); v8::Local<v8::Value> setter();
...@@ -556,7 +555,6 @@ class V8_EXPORT_PRIVATE AccessorPair : public v8::Value { ...@@ -556,7 +555,6 @@ class V8_EXPORT_PRIVATE AccessorPair : public v8::Value {
V8_INLINE static AccessorPair* Cast(v8::Value* obj); V8_INLINE static AccessorPair* Cast(v8::Value* obj);
private: private:
AccessorPair();
static void CheckCast(v8::Value* obj); static void CheckCast(v8::Value* obj);
}; };
...@@ -596,6 +594,7 @@ class PropertyIterator { ...@@ -596,6 +594,7 @@ class PropertyIterator {
// Wrapper around v8::internal::WasmValue. // Wrapper around v8::internal::WasmValue.
class V8_EXPORT_PRIVATE WasmValue : public v8::Value { class V8_EXPORT_PRIVATE WasmValue : public v8::Value {
public: public:
WasmValue() = delete;
static bool IsWasmValue(v8::Local<v8::Value> obj); static bool IsWasmValue(v8::Local<v8::Value> obj);
V8_INLINE static WasmValue* Cast(v8::Value* obj); V8_INLINE static WasmValue* Cast(v8::Value* obj);
int value_type(); int value_type();
...@@ -606,7 +605,6 @@ class V8_EXPORT_PRIVATE WasmValue : public v8::Value { ...@@ -606,7 +605,6 @@ class V8_EXPORT_PRIVATE WasmValue : public v8::Value {
v8::Local<v8::Value> ref(); v8::Local<v8::Value> ref();
private: private:
WasmValue();
static void CheckCast(v8::Value* obj); static void CheckCast(v8::Value* obj);
}; };
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment