Commit db2f0f0a authored by Clemens Backes's avatar Clemens Backes Committed by Commit Bot

[wasm] Log code objects only once

Code objects are scheduled for logging during compilation. In
{CompileToNativeModule}, we then only need to ensure that these objects
are actually logged. {LogWasmCodes} would log them independently, which
leads to duplicate logging.

R=jkummerow@chromium.org

Bug: chromium:1029470
Change-Id: I6a187f4d7adcf7ac057f3a266f66244ef7e7102f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946353Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65288}
parent 5c1ed319
...@@ -1384,8 +1384,8 @@ std::shared_ptr<NativeModule> CompileToNativeModule( ...@@ -1384,8 +1384,8 @@ std::shared_ptr<NativeModule> CompileToNativeModule(
->FinalizeJSToWasmWrappers(isolate, native_module->module(), ->FinalizeJSToWasmWrappers(isolate, native_module->module(),
export_wrappers_out); export_wrappers_out);
// Log the code within the generated module for profiling. // Ensure that the code objects are logged before returning.
native_module->LogWasmCodes(isolate); isolate->wasm_engine()->LogOutstandingCodesForIsolate(isolate);
return native_module; return native_module;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment