Commit dac922ef authored by Camillo Bruni's avatar Camillo Bruni Committed by V8 LUCI CQ

[flags] Remove FLAG_log_suspect and related code

This is no longer actively used.

Change-Id: I88b0695732ead8652a21ed5d59f3d9752c0c88d1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574551Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79826}
parent 65a8d2de
......@@ -2017,7 +2017,6 @@ DEFINE_BOOL(log_code_disassemble, false,
"Log all disassembled code to the log file.")
DEFINE_IMPLICATION(log_code_disassemble, log_code)
DEFINE_BOOL(log_handles, false, "Log global handle events.")
DEFINE_BOOL(log_suspect, false, "Log suspect operations.")
DEFINE_BOOL(log_source_code, false, "Log source code.")
DEFINE_BOOL(log_function_events, false,
"Log function events "
......
......@@ -514,7 +514,6 @@ MaybeHandle<Object> LoadIC::Load(Handle<Object> object, Handle<Name> name,
if (it.IsFound()) {
return result;
} else if (!ShouldThrowReferenceError()) {
LOG(isolate(), SuspectReadEvent(*name, *object));
return result;
}
}
......
......@@ -139,7 +139,6 @@ void V8::Initialize() {
&FLAG_log_code,
&FLAG_log_code_disassemble,
&FLAG_log_handles,
&FLAG_log_suspect,
&FLAG_log_source_code,
&FLAG_log_function_events,
&FLAG_log_internal_timer_events,
......
......@@ -1611,15 +1611,6 @@ void Logger::MoveEventInternal(LogEventsAndTags event, Address from,
msg.WriteToLogFile();
}
void Logger::SuspectReadEvent(Name name, Object obj) {
if (!FLAG_log_suspect) return;
MSG_BUILDER();
String class_name = obj.IsJSObject() ? JSObject::cast(obj).class_name()
: ReadOnlyRoots(isolate_).empty_string();
msg << "suspect-read" << kNext << class_name << kNext << name;
msg.WriteToLogFile();
}
namespace {
void AppendFunctionMessage(Log::MessageBuilder& msg, const char* reason,
int script_id, double time_delta, int start_position,
......
......@@ -148,10 +148,6 @@ class Logger : public CodeEventListener {
void NewEvent(const char* name, void* object, size_t size);
void DeleteEvent(const char* name, void* object);
// Emits an event that an undefined property was read from an
// object.
void SuspectReadEvent(Name name, Object obj);
// ==== Events logged by --log-function-events ====
void FunctionEvent(const char* reason, int script_id, double time_delta_ms,
int start_position, int end_position,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment