Commit d95cf569 authored by Yahan Lu's avatar Yahan Lu Committed by Commit Bot

[riscv64][wasm][liftoff] Record correct offset in StoreTaggedPointer

Port: a1616e6f
Change-Id: Idfb48da2e38948b23efdc129da8949200f0896c3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2814723
Commit-Queue: Brice Dobry <brice.dobry@futurewei.com>
Reviewed-by: 's avatarBrice Dobry <brice.dobry@futurewei.com>
Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74184}
parent 92d617a3
...@@ -452,7 +452,7 @@ void LiftoffAssembler::StoreTaggedPointer(Register dst_addr, ...@@ -452,7 +452,7 @@ void LiftoffAssembler::StoreTaggedPointer(Register dst_addr,
JumpIfSmi(src.gp(), &exit); JumpIfSmi(src.gp(), &exit);
CheckPageFlag(src.gp(), scratch, CheckPageFlag(src.gp(), scratch,
MemoryChunk::kPointersToHereAreInterestingMask, eq, &exit); MemoryChunk::kPointersToHereAreInterestingMask, eq, &exit);
Add64(scratch, dst_addr, offset_imm); Add64(scratch, dst_op.rm(), dst_op.offset());
CallRecordWriteStub(dst_addr, scratch, EMIT_REMEMBERED_SET, kSaveFPRegs, CallRecordWriteStub(dst_addr, scratch, EMIT_REMEMBERED_SET, kSaveFPRegs,
wasm::WasmCode::kRecordWrite); wasm::WasmCode::kRecordWrite);
bind(&exit); bind(&exit);
......
...@@ -854,10 +854,6 @@ ...@@ -854,10 +854,6 @@
}], # 'arch == riscv64' }], # 'arch == riscv64'
['arch == riscv64 and variant == stress_incremental_marking', {
# https://github.com/v8-riscv/v8/issues/414
'wasm/externref-globals-liftoff': [SKIP],
}], #'arch == riscv64 and variant == stress-incremental-marking'
############################################################################## ##############################################################################
['system == macos', { ['system == macos', {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment