Commit d6ebeb4e authored by machenbach's avatar machenbach Committed by Commit bot

[test] Make cfi more verbose.

Set "no recover" in diagnostic mode to keep triggering
crashes. Otherwise, the v8 test driver won't notice tests
as failing.

Also port some common sanitizer cflags to cfi - those can be
removed on the build side afterwards.

BUG=chromium:515782
LOG=n

Review URL: https://codereview.chromium.org/1414763004

Cr-Commit-Position: refs/heads/master@{#31442}
parent ef18438c
...@@ -492,8 +492,8 @@ ...@@ -492,8 +492,8 @@
'target_defaults': { 'target_defaults': {
'conditions': [ 'conditions': [
# Common options for AddressSanitizer, LeakSanitizer, # Common options for AddressSanitizer, LeakSanitizer,
# ThreadSanitizer and MemorySanitizer. # ThreadSanitizer, MemorySanitizer and CFI builds.
['asan==1 or lsan==1 or tsan==1 or msan==1', { ['asan==1 or lsan==1 or tsan==1 or msan==1 or cfi_vptr==1', {
'target_conditions': [ 'target_conditions': [
['_toolset=="target"', { ['_toolset=="target"', {
'cflags': [ 'cflags': [
...@@ -1275,7 +1275,7 @@ ...@@ -1275,7 +1275,7 @@
['_toolset=="target"', { ['_toolset=="target"', {
'cflags': [ 'cflags': [
'-fno-sanitize-trap=cfi', '-fno-sanitize-trap=cfi',
'-fsanitize-recover=cfi', '-fno-sanitize-recover=cfi',
], ],
'cflags_cc!': [ 'cflags_cc!': [
'-fno-rtti', '-fno-rtti',
...@@ -1285,7 +1285,7 @@ ...@@ -1285,7 +1285,7 @@
], ],
'ldflags': [ 'ldflags': [
'-fno-sanitize-trap=cfi', '-fno-sanitize-trap=cfi',
'-fsanitize-recover=cfi', '-fno-sanitize-recover=cfi',
], ],
}], }],
], ],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment