Revert "[heap] Reland: Reuse object evacuation information for slot recording in Scavenger."

This reverts commit 0d66b4d8.

Reason for revert:
https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/22200

Original change's description:
> [heap] Reland: Reuse object evacuation information for slot recording in Scavenger.
> 
> This reverts commit 136ecbb9.
> 
> Bug: chromium:852420
> Change-Id: I4fab9d6ed7b18085352fa7488c2849b90588deaf
> Reviewed-on: https://chromium-review.googlesource.com/1189802
> Commit-Queue: Hannes Payer <hpayer@chromium.org>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55467}

TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org

Change-Id: I03991a02eb5e06e7db91f88462232dde4bd97f49
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:852420
Reviewed-on: https://chromium-review.googlesource.com/1194005Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55468}

src/heap/scavenger.cc

@@ -53,13 +53,15 @@ class IterateAndScavengePromotedObjectsVisitor final : public ObjectVisitor {
     scavenger_->PageMemoryFence(reinterpret_cast<MaybeObject*>(target));
 
     if (Heap::InFromSpace(target)) {
-      SlotCallbackResult result = scavenger_->ScavengeObject(slot, target);
+      scavenger_->ScavengeObject(slot, target);
       bool success = (*slot)->ToStrongOrWeakHeapObject(&target);
       USE(success);
       DCHECK(success);
+      scavenger_->PageMemoryFence(reinterpret_cast<MaybeObject*>(target));
 
-      if (result == KEEP_SLOT) {
+      if (Heap::InNewSpace(target)) {
         SLOW_DCHECK(target->IsHeapObject());
+        SLOW_DCHECK(Heap::InToSpace(target));
         RememberedSet<OLD_TO_NEW>::Insert(Page::FromAddress(slot_address),
                                           slot_address);
       }

src/heap/scavenger.h

@@ -16,12 +16,6 @@ namespace internal {
 
 class OneshotBarrier;
 
-enum class CopyAndForwardResult {
-  SUCCESS_YOUNG_GENERATION,
-  SUCCESS_OLD_GENERATION,
-  FAILURE
-};
-
 class Scavenger {
  public:
   static const int kCopiedListSegmentSize = 256;
@@ -67,43 +61,34 @@ class Scavenger {
 
   // Scavenges an object |object| referenced from slot |p|. |object| is required
   // to be in from space.
-  inline SlotCallbackResult ScavengeObject(HeapObjectReference** p,
-                                           HeapObject* object);
+  inline void ScavengeObject(HeapObjectReference** p, HeapObject* object);
 
   // Copies |source| to |target| and sets the forwarding pointer in |source|.
   V8_INLINE bool MigrateObject(Map* map, HeapObject* source, HeapObject* target,
                                int size);
 
-  V8_INLINE SlotCallbackResult
-  RememberedSetEntryNeeded(CopyAndForwardResult result);
+  V8_INLINE bool SemiSpaceCopyObject(Map* map, HeapObjectReference** slot,
+                                     HeapObject* object, int object_size);
 
-  V8_INLINE CopyAndForwardResult SemiSpaceCopyObject(Map* map,
-                                                     HeapObjectReference** slot,
-                                                     HeapObject* object,
-                                                     int object_size);
+  V8_INLINE bool PromoteObject(Map* map, HeapObjectReference** slot,
+                               HeapObject* object, int object_size);
 
-  V8_INLINE CopyAndForwardResult PromoteObject(Map* map,
-                                               HeapObjectReference** slot,
-                                               HeapObject* object,
-                                               int object_size);
-
-  V8_INLINE SlotCallbackResult EvacuateObject(HeapObjectReference** slot,
-                                              Map* map, HeapObject* source);
+  V8_INLINE void EvacuateObject(HeapObjectReference** slot, Map* map,
+                                HeapObject* source);
 
   // Different cases for object evacuation.
-  V8_INLINE SlotCallbackResult EvacuateObjectDefault(Map* map,
-                                                     HeapObjectReference** slot,
-                                                     HeapObject* object,
-                                                     int object_size);
-
-  inline SlotCallbackResult EvacuateThinString(Map* map, HeapObject** slot,
-                                               ThinString* object,
-                                               int object_size);
-
-  inline SlotCallbackResult EvacuateShortcutCandidate(Map* map,
-                                                      HeapObject** slot,
-                                                      ConsString* object,
-                                                      int object_size);
+
+  V8_INLINE void EvacuateObjectDefault(Map* map, HeapObjectReference** slot,
+                                       HeapObject* object, int object_size);
+
+  V8_INLINE void EvacuateJSFunction(Map* map, HeapObject** slot,
+                                    JSFunction* object, int object_size);
+
+  inline void EvacuateThinString(Map* map, HeapObject** slot,
+                                 ThinString* object, int object_size);
+
+  inline void EvacuateShortcutCandidate(Map* map, HeapObject** slot,
+                                        ConsString* object, int object_size);
 
   void IterateAndScavengePromotedObject(HeapObject* target, int size);