Commit d6569052 authored by Zhi An Ng's avatar Zhi An Ng Committed by Commit Bot

Revert "[wasm-simd][liftoff] Check CpuFeatures for SIMD support"

This reverts commit 7c32fa05.

Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux/35618
Need to update expected test output.

Original change's description:
> [wasm-simd][liftoff] Check CpuFeatures for SIMD support
> 
> If Wasm simd128 is not supported on this particular hardware, we bail
> out to TurboFan.
> 
> Bug: v8:9909
> Change-Id: Ie46e154426783ba099b7c0facc906670cda1bdd0
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2029427
> Reviewed-by: Clemens Backes <clemensb@chromium.org>
> Commit-Queue: Zhi An Ng <zhin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#66055}

TBR=gdeepti@chromium.org,clemensb@chromium.org,zhin@chromium.org

Change-Id: I7def513a619c609ff820ff1b9aefa92e1741e4a2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:9909
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2031888Reviewed-by: 's avatarZhi An Ng <zhin@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#66058}
parent 19bc0ea2
...@@ -357,11 +357,6 @@ class LiftoffCompiler { ...@@ -357,11 +357,6 @@ class LiftoffCompiler {
bool CheckSupportedType(FullDecoder* decoder, bool CheckSupportedType(FullDecoder* decoder,
Vector<const ValueType> supported_types, Vector<const ValueType> supported_types,
ValueType type, const char* context) { ValueType type, const char* context) {
// Special case for kWasm128 which requires specific hardware support.
if (type == kWasmS128 && (!CpuFeatures::SupportsWasmSimd128())) {
unsupported(decoder, kSimd, "simd");
return false;
}
// Check supported types. // Check supported types.
for (ValueType supported : supported_types) { for (ValueType supported : supported_types) {
if (type == supported) return true; if (type == supported) return true;
...@@ -2203,9 +2198,6 @@ class LiftoffCompiler { ...@@ -2203,9 +2198,6 @@ class LiftoffCompiler {
void SimdOp(FullDecoder* decoder, WasmOpcode opcode, Vector<Value> args, void SimdOp(FullDecoder* decoder, WasmOpcode opcode, Vector<Value> args,
Value* result) { Value* result) {
if (!CpuFeatures::SupportsWasmSimd128()) {
return unsupported(decoder, kSimd, "simd");
}
switch (opcode) { switch (opcode) {
case wasm::kExprF32x4Splat: case wasm::kExprF32x4Splat:
EmitUnOp<kWasmF32, kWasmS128>( EmitUnOp<kWasmF32, kWasmS128>(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment