Commit d649229d authored by Jakob Gruber's avatar Jakob Gruber Committed by Commit Bot

Fix machine graph verifier error

... introduced by
https://chromium-review.googlesource.com/c/v8/v8/+/2336793/

The parameter is called 'is_stub', but actually means 'not optimized
JS code, nor wasm'.

Tbr: leszeks@chromium.org
Bug: v8:8888
Change-Id: I1dc2cf95cca6af5dd584dd889324edc94f44a628
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339314Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69248}
parent beebee4f
......@@ -3314,10 +3314,13 @@ bool PipelineImpl::SelectInstructions(Linkage* linkage) {
<< "--- End of " << data->debug_name() << " generated by TurboFan\n"
<< "--------------------------------------------------\n";
}
// TODO(jgruber): The parameter is called is_stub but actually contains
// something different. Update either the name or its contents.
const bool is_stub =
!data->info()->IsOptimizing() && !data->info()->IsWasm();
Zone temp_zone(data->allocator(), kMachineGraphVerifierZoneName);
MachineGraphVerifier::Run(data->graph(), data->schedule(), linkage,
data->info()->IsStub(), data->debug_name(),
&temp_zone);
MachineGraphVerifier::Run(data->graph(), data->schedule(), linkage, is_stub,
data->debug_name(), &temp_zone);
}
data->InitializeInstructionSequence(call_descriptor);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment