[test] Pull exit-code logic to shared base runner

This makes the test runner and numfuzz share the same exit code behavior on
errors. This is needed as they also share the same infrastructure logic
to collect swarming tasks.

Bug: chromium:937228
Change-Id: I155b37c7b10dd22959a4dcf30bbd0321c452236b
Reviewed-on: https://chromium-review.googlesource.com/c/1495987Reviewed-by: Tamer Tas <tmrts@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59976}

tools/testrunner/base_runner.py

@@ -270,7 +270,12 @@ class BaseTestRunner(object):
       self._setup_env()
       print(">>> Running tests for %s.%s" % (self.build_config.arch,
                                             self.mode_name))
-      return self._do_execute(tests, args, options)
+      exit_code = self._do_execute(tests, args, options)
+      if exit_code == utils.EXIT_CODE_FAILURES and options.json_test_results:
+        print("Force exit code 0 after failures. Json test results file "
+              "generated with failure information.")
+        exit_code = utils.EXIT_CODE_PASS
+      return exit_code
     except TestRunnerError:
       traceback.print_exc()
       return utils.EXIT_CODE_INTERNAL_ERROR

tools/testrunner/standard_runner.py

@@ -342,13 +342,7 @@ class StandardTestRunner(base_runner.BaseTestRunner):
         exit_code = utils.EXIT_CODE_NO_TESTS
 
       # Indicate if a SIGINT or SIGTERM happened.
-      exit_code = max(exit_code, sigproc.exit_code)
-
-      if exit_code == utils.EXIT_CODE_FAILURES and options.json_test_results:
-        print("Force exit code 0 after failures. Json test results file "
-              "generated with failure information.")
-        exit_code = utils.EXIT_CODE_PASS
-      return exit_code
+      return max(exit_code, sigproc.exit_code)
 
     def _create_predictable_filter(self):
       if not self.build_config.predictable: