Commit d4cf7d1f authored by Jakob Gruber's avatar Jakob Gruber Committed by Commit Bot

Fix various typos (and add one DCHECK)

A random grab-bag of trivial fixes I came across while working on
another CL.

Bug: v8:8888
Change-Id: I6e46e1fe5a547854d8afbac19f7e049f1661c406
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2388113
Auto-Submit: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69675}
parent 9d413c63
...@@ -1026,8 +1026,8 @@ MaybeHandle<Code> GetOptimizedCode(Handle<JSFunction> function, ...@@ -1026,8 +1026,8 @@ MaybeHandle<Code> GetOptimizedCode(Handle<JSFunction> function,
// turbo_filter. // turbo_filter.
if (!FLAG_opt || !shared->PassesFilter(FLAG_turbo_filter)) return {}; if (!FLAG_opt || !shared->PassesFilter(FLAG_turbo_filter)) return {};
// If code was pending optimization for testing, delete remove the entry // If code was pending optimization for testing, remove the entry from the
// from the table that was preventing the bytecode from being flushed // table that was preventing the bytecode from being flushed.
if (V8_UNLIKELY(FLAG_testing_d8_test_runner)) { if (V8_UNLIKELY(FLAG_testing_d8_test_runner)) {
PendingOptimizationTable::FunctionWasOptimized(isolate, function); PendingOptimizationTable::FunctionWasOptimized(isolate, function);
} }
...@@ -1073,7 +1073,7 @@ MaybeHandle<Code> GetOptimizedCode(Handle<JSFunction> function, ...@@ -1073,7 +1073,7 @@ MaybeHandle<Code> GetOptimizedCode(Handle<JSFunction> function,
has_script, osr_offset, osr_frame)); has_script, osr_offset, osr_frame));
OptimizedCompilationInfo* compilation_info = job->compilation_info(); OptimizedCompilationInfo* compilation_info = job->compilation_info();
// Prepare the job and launch cocncurrent compilation, or compile now. // Prepare the job and launch concurrent compilation, or compile now.
if (mode == ConcurrencyMode::kConcurrent) { if (mode == ConcurrencyMode::kConcurrent) {
if (GetOptimizedCodeLater(std::move(job), isolate, compilation_info, if (GetOptimizedCodeLater(std::move(job), isolate, compilation_info,
code_kind, function)) { code_kind, function)) {
......
...@@ -310,11 +310,11 @@ class V8_EXPORT_PRIVATE CodeGenerator final : public GapResolver::Assembler { ...@@ -310,11 +310,11 @@ class V8_EXPORT_PRIVATE CodeGenerator final : public GapResolver::Assembler {
static bool IsValidPush(InstructionOperand source, PushTypeFlags push_type); static bool IsValidPush(InstructionOperand source, PushTypeFlags push_type);
// Generate a list moves from an instruction that are candidates to be turned // Generate a list of moves from an instruction that are candidates to be
// into push instructions on platforms that support them. In general, the list // turned into push instructions on platforms that support them. In general,
// of push candidates are moves to a set of contiguous destination // the list of push candidates are moves to a set of contiguous destination
// InstructionOperand locations on the stack that don't clobber values that // InstructionOperand locations on the stack that don't clobber values that
// are needed for resolve the gap or use values generated by the gap, // are needed to resolve the gap or use values generated by the gap,
// i.e. moves that can be hoisted together before the actual gap and assembled // i.e. moves that can be hoisted together before the actual gap and assembled
// together. // together.
static void GetPushCompatibleMoves(Instruction* instr, static void GetPushCompatibleMoves(Instruction* instr,
......
...@@ -103,6 +103,7 @@ int CallDescriptor::GetStackParameterDelta( ...@@ -103,6 +103,7 @@ int CallDescriptor::GetStackParameterDelta(
// of padding. // of padding.
++stack_param_delta; ++stack_param_delta;
} else { } else {
DCHECK_NE(tail_caller_slots_above_sp % 2, 0);
// The delta is odd because of the caller. We already have one slot of // The delta is odd because of the caller. We already have one slot of
// padding that we can reuse for arguments, so we will need one fewer // padding that we can reuse for arguments, so we will need one fewer
// slot. // slot.
......
...@@ -80,7 +80,7 @@ void TraceInOptimizationQueue(JSFunction function) { ...@@ -80,7 +80,7 @@ void TraceInOptimizationQueue(JSFunction function) {
if (FLAG_trace_opt_verbose) { if (FLAG_trace_opt_verbose) {
PrintF("[function "); PrintF("[function ");
function.PrintName(); function.PrintName();
PrintF(" has been marked manually for optimization]\n"); PrintF(" is already in optimization queue]\n");
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment