Commit d423178d authored by Victor Gomes's avatar Victor Gomes Committed by V8 LUCI CQ

[maglev] Create test variant

Bug: v8:7700
Change-Id: Icd9c0ce6fce727759beec246253dbd16756abc09
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545166
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79567}
parent 866785dd
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
// Flags: --no-stress-flush-code // Flags: --no-stress-flush-code
// Flags: --no-stress-incremental-marking // Flags: --no-stress-incremental-marking
// Flags: --no-concurrent-recompilation // Flags: --no-concurrent-recompilation
// Flags: --no-maglev
var source = var source =
` `
......
...@@ -7,6 +7,7 @@ ...@@ -7,6 +7,7 @@
// Flags: --no-stress-incremental-marking // Flags: --no-stress-incremental-marking
// Flags: --no-concurrent-recompilation // Flags: --no-concurrent-recompilation
// Flags: --no-baseline-batch-compilation // Flags: --no-baseline-batch-compilation
// Flags: --no-maglev
var source = var source =
` `
......
...@@ -89,4 +89,12 @@ ...@@ -89,4 +89,12 @@
'*': [SKIP], # only relevant for mjsunit tests. '*': [SKIP], # only relevant for mjsunit tests.
}], }],
##############################################################################
['variant == maglev', {
# TODO(v8:7700): This test is in an infinite loop. The loop condition checks
# if the function is optimized, but maglev fails with unsupported bytecode.
# Re-enable this when maglev support all bytecodes.
'string-localecompare': [SKIP],
}], # variant == maglev
] ]
...@@ -1513,6 +1513,14 @@ ...@@ -1513,6 +1513,14 @@
'harmony/sharedarraybuffer-worker-gc-stress': [SKIP], 'harmony/sharedarraybuffer-worker-gc-stress': [SKIP],
}], # variant == stress_concurrent_allocation }], # variant == stress_concurrent_allocation
##############################################################################
['variant == maglev', {
# TODO(v8:7700): These tests assume that optimization always succeed.
# Change this when maglev support all bytecodes.
'interrupt-budget-override': [SKIP],
'never-optimize': [SKIP],
}], # variant == maglev
############################################################################## ##############################################################################
['no_simd_hardware == True', { ['no_simd_hardware == True', {
'wasm/exceptions-simd': [SKIP], 'wasm/exceptions-simd': [SKIP],
......
...@@ -15,8 +15,10 @@ ALL_VARIANT_FLAGS = { ...@@ -15,8 +15,10 @@ ALL_VARIANT_FLAGS = {
"experimental_regexp": [["--default-to-experimental-regexp-engine"]], "experimental_regexp": [["--default-to-experimental-regexp-engine"]],
"jitless": [["--jitless"]], "jitless": [["--jitless"]],
"sparkplug": [["--sparkplug"]], "sparkplug": [["--sparkplug"]],
# TODO(v8:v8:7700): Support concurrent compilation and remove flag.
"maglev": [["--maglev", "--no-concurrent-recompilation"]],
"concurrent_sparkplug": [["--concurrent-sparkplug", "--sparkplug"]], "concurrent_sparkplug": [["--concurrent-sparkplug", "--sparkplug"]],
"always_sparkplug": [[ "--always-sparkplug", "--sparkplug"]], "always_sparkplug": [["--always-sparkplug", "--sparkplug"]],
"minor_mc": [["--minor-mc"]], "minor_mc": [["--minor-mc"]],
"no_lfa": [["--no-lazy-feedback-allocation"]], "no_lfa": [["--no-lazy-feedback-allocation"]],
# No optimization means disable all optimizations. OptimizeFunctionOnNextCall # No optimization means disable all optimizations. OptimizeFunctionOnNextCall
...@@ -52,7 +54,7 @@ ALL_VARIANT_FLAGS = { ...@@ -52,7 +54,7 @@ ALL_VARIANT_FLAGS = {
INCOMPATIBLE_FLAGS_PER_VARIANT = { INCOMPATIBLE_FLAGS_PER_VARIANT = {
"jitless": [ "jitless": [
"--opt", "--always-opt", "--liftoff", "--track-field-types", "--opt", "--always-opt", "--liftoff", "--track-field-types",
"--validate-asm", "--sparkplug", "--concurrent-sparkplug", "--validate-asm", "--sparkplug", "--concurrent-sparkplug", "--maglev",
"--always-sparkplug", "--regexp-tier-up", "--no-regexp-interpret-all", "--always-sparkplug", "--regexp-tier-up", "--no-regexp-interpret-all",
"--maglev" "--maglev"
], ],
...@@ -76,6 +78,11 @@ INCOMPATIBLE_FLAGS_PER_VARIANT = { ...@@ -76,6 +78,11 @@ INCOMPATIBLE_FLAGS_PER_VARIANT = {
], ],
"sparkplug": ["--jitless"], "sparkplug": ["--jitless"],
"concurrent_sparkplug": ["--jitless"], "concurrent_sparkplug": ["--jitless"],
# TODO(v8:v8:7700): Support concurrent compilation and remove incompatible flags.
"maglev": [
"--jitless", "--concurrent-recompilation",
"--stress-concurrent-inlining"
],
"always_sparkplug": ["--jitless"], "always_sparkplug": ["--jitless"],
"code_serializer": [ "code_serializer": [
"--cache=after-execute", "--cache=full-code-cache", "--cache=none" "--cache=after-execute", "--cache=full-code-cache", "--cache=none"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment