Commit d4219df6 authored by Takuto Ikuta's avatar Takuto Ikuta Committed by Commit Bot

Remove V8_INLINE from non-inlineable function from parser.h

I will enable /Zc:DllexportInlines- flags for faster build time on windows.
But the flag makes clang's -Wundefined-inline check more strict as a secondary effect.

Actually, having inline function specifier for the function not defined in header file seems bit strange.
Let me remove inline specifier from such functions.

Bug: chromium:857548, chromium:901709
Change-Id: Ic06d10e2445cfedc7af67b72154f93a51ac26853
Reviewed-on: https://chromium-review.googlesource.com/c/1186017
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57229}
parent eab36a24
...@@ -330,29 +330,25 @@ class V8_EXPORT_PRIVATE Parser : public NON_EXPORTED_BASE(ParserBase<Parser>) { ...@@ -330,29 +330,25 @@ class V8_EXPORT_PRIVATE Parser : public NON_EXPORTED_BASE(ParserBase<Parser>) {
FunctionLiteral* CreateInitializerFunction( FunctionLiteral* CreateInitializerFunction(
const char* name, DeclarationScope* scope, const char* name, DeclarationScope* scope,
ZonePtrList<ClassLiteral::Property>* fields); ZonePtrList<ClassLiteral::Property>* fields);
V8_INLINE Statement* DeclareClass(const AstRawString* variable_name,
Expression* value, Statement* DeclareClass(const AstRawString* variable_name, Expression* value,
ZonePtrList<const AstRawString>* names, ZonePtrList<const AstRawString>* names,
int class_token_pos, int end_pos); int class_token_pos, int end_pos);
V8_INLINE void DeclareClassVariable(const AstRawString* name, void DeclareClassVariable(const AstRawString* name, ClassInfo* class_info,
ClassInfo* class_info,
int class_token_pos); int class_token_pos);
V8_INLINE void DeclareClassProperty(const AstRawString* class_name, void DeclareClassProperty(const AstRawString* class_name,
ClassLiteralProperty* property, ClassLiteralProperty* property,
const AstRawString* property_name, const AstRawString* property_name,
ClassLiteralProperty::Kind kind, ClassLiteralProperty::Kind kind, bool is_static,
bool is_static, bool is_constructor, bool is_constructor, bool is_computed_name,
bool is_computed_name, bool is_private, bool is_private, ClassInfo* class_info);
ClassInfo* class_info); Expression* RewriteClassLiteral(Scope* block_scope, const AstRawString* name,
V8_INLINE Expression* RewriteClassLiteral(Scope* block_scope, ClassInfo* class_info, int pos, int end_pos);
const AstRawString* name, Statement* DeclareNative(const AstRawString* name, int pos);
ClassInfo* class_info, int pos,
int end_pos);
V8_INLINE Statement* DeclareNative(const AstRawString* name, int pos);
V8_INLINE Block* IgnoreCompletion(Statement* statement); Block* IgnoreCompletion(Statement* statement);
V8_INLINE Scope* NewHiddenCatchScope(); Scope* NewHiddenCatchScope();
// PatternRewriter and associated methods defined in pattern-rewriter.cc. // PatternRewriter and associated methods defined in pattern-rewriter.cc.
friend class PatternRewriter; friend class PatternRewriter;
...@@ -537,11 +533,11 @@ class V8_EXPORT_PRIVATE Parser : public NON_EXPORTED_BASE(ParserBase<Parser>) { ...@@ -537,11 +533,11 @@ class V8_EXPORT_PRIVATE Parser : public NON_EXPORTED_BASE(ParserBase<Parser>) {
void SetAsmModule(); void SetAsmModule();
// Rewrite all DestructuringAssignments in the current FunctionState. // Rewrite all DestructuringAssignments in the current FunctionState.
V8_INLINE void RewriteDestructuringAssignments(); void RewriteDestructuringAssignments();
Expression* RewriteSpreads(ArrayLiteral* lit); Expression* RewriteSpreads(ArrayLiteral* lit);
V8_INLINE void QueueDestructuringAssignmentForRewriting( void QueueDestructuringAssignmentForRewriting(
RewritableExpression* assignment); RewritableExpression* assignment);
friend class InitializerRewriter; friend class InitializerRewriter;
...@@ -571,8 +567,7 @@ class V8_EXPORT_PRIVATE Parser : public NON_EXPORTED_BASE(ParserBase<Parser>) { ...@@ -571,8 +567,7 @@ class V8_EXPORT_PRIVATE Parser : public NON_EXPORTED_BASE(ParserBase<Parser>) {
IteratorType type); IteratorType type);
Statement* CheckCallable(Variable* var, Expression* error, int pos); Statement* CheckCallable(Variable* var, Expression* error, int pos);
V8_INLINE void RewriteAsyncFunctionBody(ZonePtrList<Statement>* body, void RewriteAsyncFunctionBody(ZonePtrList<Statement>* body, Block* block,
Block* block,
Expression* return_value); Expression* return_value);
void AddArrowFunctionFormalParameters(ParserFormalParameters* parameters, void AddArrowFunctionFormalParameters(ParserFormalParameters* parameters,
...@@ -883,9 +878,8 @@ class V8_EXPORT_PRIVATE Parser : public NON_EXPORTED_BASE(ParserBase<Parser>) { ...@@ -883,9 +878,8 @@ class V8_EXPORT_PRIVATE Parser : public NON_EXPORTED_BASE(ParserBase<Parser>) {
return new (zone()) ZonePtrList<Statement>(size, zone()); return new (zone()) ZonePtrList<Statement>(size, zone());
} }
V8_INLINE Expression* NewV8Intrinsic(const AstRawString* name, Expression* NewV8Intrinsic(const AstRawString* name,
const ScopedPtrList<Expression>& args, const ScopedPtrList<Expression>& args, int pos);
int pos);
V8_INLINE Statement* NewThrowStatement(Expression* exception, int pos) { V8_INLINE Statement* NewThrowStatement(Expression* exception, int pos) {
return factory()->NewExpressionStatement( return factory()->NewExpressionStatement(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment