Commit d0bbd542 authored by bmeurer's avatar bmeurer Committed by Commit bot

[runtime] Remove obsolete %GetPropertyNames runtime entry.

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/1281533003

Cr-Commit-Position: refs/heads/master@{#30086}
parent 0e5ec1b9
...@@ -658,7 +658,6 @@ double AggregatedMemoryHistogram<Histogram>::Aggregate(double current_ms, ...@@ -658,7 +658,6 @@ double AggregatedMemoryHistogram<Histogram>::Aggregate(double current_ms,
SC(megamorphic_stub_cache_updates, V8.MegamorphicStubCacheUpdates) \ SC(megamorphic_stub_cache_updates, V8.MegamorphicStubCacheUpdates) \
SC(array_function_runtime, V8.ArrayFunctionRuntime) \ SC(array_function_runtime, V8.ArrayFunctionRuntime) \
SC(array_function_native, V8.ArrayFunctionNative) \ SC(array_function_native, V8.ArrayFunctionNative) \
SC(for_in, V8.ForIn) \
SC(enum_cache_hits, V8.EnumCacheHits) \ SC(enum_cache_hits, V8.EnumCacheHits) \
SC(enum_cache_misses, V8.EnumCacheMisses) \ SC(enum_cache_misses, V8.EnumCacheMisses) \
SC(fast_new_closure_total, V8.FastNewClosureTotal) \ SC(fast_new_closure_total, V8.FastNewClosureTotal) \
......
...@@ -794,26 +794,10 @@ RUNTIME_FUNCTION(Runtime_IsPropertyEnumerable) { ...@@ -794,26 +794,10 @@ RUNTIME_FUNCTION(Runtime_IsPropertyEnumerable) {
} }
RUNTIME_FUNCTION(Runtime_GetPropertyNames) { // Returns either a FixedArray or, if the given object has an enum cache that
HandleScope scope(isolate); // contains all enumerable properties of the object and its prototypes have
DCHECK(args.length() == 1); // none, the map of the object. This is used to speed up the check for
CONVERT_ARG_HANDLE_CHECKED(JSReceiver, object, 0); // deletions during a for-in.
Handle<JSArray> result;
isolate->counters()->for_in()->Increment();
Handle<FixedArray> elements;
ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
isolate, elements,
JSReceiver::GetKeys(object, JSReceiver::INCLUDE_PROTOS));
return *isolate->factory()->NewJSArrayWithElements(elements);
}
// Returns either a FixedArray as Runtime_GetPropertyNames,
// or, if the given object has an enum cache that contains
// all enumerable properties of the object and its prototypes
// have none, the map of the object. This is used to speed up
// the check for deletions during a for-in.
RUNTIME_FUNCTION(Runtime_GetPropertyNamesFast) { RUNTIME_FUNCTION(Runtime_GetPropertyNamesFast) {
SealHandleScope shs(isolate); SealHandleScope shs(isolate);
DCHECK(args.length() == 1); DCHECK(args.length() == 1);
......
...@@ -454,7 +454,6 @@ namespace internal { ...@@ -454,7 +454,6 @@ namespace internal {
F(HasProperty, 2, 1) \ F(HasProperty, 2, 1) \
F(HasElement, 2, 1) \ F(HasElement, 2, 1) \
F(IsPropertyEnumerable, 2, 1) \ F(IsPropertyEnumerable, 2, 1) \
F(GetPropertyNames, 1, 1) \
F(GetPropertyNamesFast, 1, 1) \ F(GetPropertyNamesFast, 1, 1) \
F(GetOwnPropertyNames, 2, 1) \ F(GetOwnPropertyNames, 2, 1) \
F(GetOwnElementNames, 1, 1) \ F(GetOwnElementNames, 1, 1) \
......
...@@ -489,17 +489,6 @@ test_for_in(); ...@@ -489,17 +489,6 @@ test_for_in();
test_for_in(); test_for_in();
test_for_in(); test_for_in();
function test_get_property_names() {
names = %GetPropertyNames(large_array3);
property_name_count = 0;
for (x in names) { property_name_count++; };
assertEquals(26, property_name_count);
}
test_get_property_names();
test_get_property_names();
test_get_property_names();
// Test elements getters. // Test elements getters.
assertEquals(expected_array_value(10), large_array3[10]); assertEquals(expected_array_value(10), large_array3[10]);
assertEquals(expected_array_value(-NaN), large_array3[2]); assertEquals(expected_array_value(-NaN), large_array3[2]);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment