Commit d0a0d1bc authored by Leszek Swirski's avatar Leszek Swirski Committed by V8 LUCI CQ

Revert "[rab/gsab] Fix accessing raw byte length"

This reverts commit fb19bc36.

Reason for revert: Test is flaky (see https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket/8807487788813571761/+/u/Check_-_isolates__flakes_/regress-crbug-1347721)

Original change's description:
> [rab/gsab] Fix accessing raw byte length
>
> Bug: v8:11111,chromium:1347721
> Change-Id: Idff4256f6720841ca4dee8f691babe7245277046
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782812
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
> Auto-Submit: Marja Hölttä <marja@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#81995}

Bug: v8:11111,chromium:1347721
Change-Id: Ib29bd8fad1227acb21c79378c71ed081ba8b4914
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3789505
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#82007}
parent 1a061c8f
...@@ -3735,8 +3735,8 @@ class TypedElementsAccessor ...@@ -3735,8 +3735,8 @@ class TypedElementsAccessor
uint8_t* source_data = static_cast<uint8_t*>(source.DataPtr()); uint8_t* source_data = static_cast<uint8_t*>(source.DataPtr());
uint8_t* dest_data = static_cast<uint8_t*>(destination.DataPtr()); uint8_t* dest_data = static_cast<uint8_t*>(destination.DataPtr());
size_t source_byte_length = source.GetByteLength(); size_t source_byte_length = source.byte_length();
size_t dest_byte_length = destination.GetByteLength(); size_t dest_byte_length = destination.byte_length();
bool source_shared = source.buffer().is_shared(); bool source_shared = source.buffer().is_shared();
bool destination_shared = destination.buffer().is_shared(); bool destination_shared = destination.buffer().is_shared();
......
// Copyright 2022 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --harmony-rab-gsab
for (let i = 0; i < 10000; i++) {
const rab = new ArrayBuffer(1632, {"maxByteLength": 9943683});
const ta1 = new Uint32Array(rab);
const ta2 = new Float32Array(rab);
rab.resize(2004);
ta1["set"](ta2);
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment