Commit cfbca60b authored by Clemens Hammacher's avatar Clemens Hammacher Committed by Commit Bot

[Liftoff] Remove unreachable code

Since f32 and f64 constants are loaded into registers right away, we
never need to spill them as constants later.

R=titzer@chromium.org

Bug: v8:6600
Change-Id: I7da91bb995e5127b0a9cb1a12a0fcd6566ed98ff
Reviewed-on: https://chromium-review.googlesource.com/960943Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51915}
parent af667f93
...@@ -379,10 +379,8 @@ void LiftoffAssembler::Spill(uint32_t index, WasmValue value) { ...@@ -379,10 +379,8 @@ void LiftoffAssembler::Spill(uint32_t index, WasmValue value) {
mov(liftoff::GetHalfStackSlot(2 * index + 1), Immediate(high_word)); mov(liftoff::GetHalfStackSlot(2 * index + 1), Immediate(high_word));
break; break;
} }
case kWasmF32:
mov(dst, Immediate(value.to_f32_boxed().get_bits()));
break;
default: default:
// We do not track f32 and f64 constants, hence they are unreachable.
UNREACHABLE(); UNREACHABLE();
} }
} }
......
...@@ -328,10 +328,8 @@ void LiftoffAssembler::Spill(uint32_t index, WasmValue value) { ...@@ -328,10 +328,8 @@ void LiftoffAssembler::Spill(uint32_t index, WasmValue value) {
movl(liftoff::GetHalfStackSlot(2 * index + 1), Immediate(high_word)); movl(liftoff::GetHalfStackSlot(2 * index + 1), Immediate(high_word));
break; break;
} }
case kWasmF32:
movl(dst, Immediate(value.to_f32_boxed().get_bits()));
break;
default: default:
// We do not track f32 and f64 constants, hence they are unreachable.
UNREACHABLE(); UNREACHABLE();
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment