Commit cebbf610 authored by Ng Zhi An's avatar Ng Zhi An Committed by Commit Bot

[clang-tidy] Add override to overridden destructors

See
https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html
for more on this warning.

Bug: v8:10488
Change-Id: Icfb54d8f4ab0efe0fdf51bd1920511b7505207d0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2223234Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68120}
parent ba3a9424
...@@ -1539,7 +1539,7 @@ class AsyncStreamingProcessor final : public StreamingProcessor { ...@@ -1539,7 +1539,7 @@ class AsyncStreamingProcessor final : public StreamingProcessor {
std::shared_ptr<Counters> counters, std::shared_ptr<Counters> counters,
AccountingAllocator* allocator); AccountingAllocator* allocator);
~AsyncStreamingProcessor(); ~AsyncStreamingProcessor() override;
bool ProcessModuleHeader(Vector<const uint8_t> bytes, bool ProcessModuleHeader(Vector<const uint8_t> bytes,
uint32_t offset) override; uint32_t offset) override;
......
...@@ -55,7 +55,7 @@ class LogCodesTask : public Task { ...@@ -55,7 +55,7 @@ class LogCodesTask : public Task {
DCHECK_NOT_NULL(isolate); DCHECK_NOT_NULL(isolate);
} }
~LogCodesTask() { ~LogCodesTask() override {
// If the platform deletes this task before executing it, we also deregister // If the platform deletes this task before executing it, we also deregister
// it to avoid use-after-free from still-running background threads. // it to avoid use-after-free from still-running background threads.
if (!cancelled()) DeregisterTask(); if (!cancelled()) DeregisterTask();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment