Commit ceadddd1 authored by franzih's avatar franzih Committed by Commit bot

[api] Disable copy constructors in the public section.

According to our style guide on Copyable and Movable Types,
copy/move operators should be disabled in the public: section, not
in the private: section.

BUG=

Review-Url: https://codereview.chromium.org/2278573002
Cr-Commit-Position: refs/heads/master@{#38872}
parent 78131aa1
...@@ -615,6 +615,9 @@ template <class T> class PersistentBase { ...@@ -615,6 +615,9 @@ template <class T> class PersistentBase {
*/ */
V8_INLINE uint16_t WrapperClassId() const; V8_INLINE uint16_t WrapperClassId() const;
PersistentBase(const PersistentBase& other) = delete; // NOLINT
void operator=(const PersistentBase&) = delete;
private: private:
friend class Isolate; friend class Isolate;
friend class Utils; friend class Utils;
...@@ -630,8 +633,6 @@ template <class T> class PersistentBase { ...@@ -630,8 +633,6 @@ template <class T> class PersistentBase {
friend class Object; friend class Object;
explicit V8_INLINE PersistentBase(T* val) : val_(val) {} explicit V8_INLINE PersistentBase(T* val) : val_(val) {}
PersistentBase(const PersistentBase& other) = delete; // NOLINT
void operator=(const PersistentBase&) = delete;
V8_INLINE static T* New(Isolate* isolate, T* that); V8_INLINE static T* New(Isolate* isolate, T* that);
T* val_; T* val_;
...@@ -835,11 +836,12 @@ class Global : public PersistentBase<T> { ...@@ -835,11 +836,12 @@ class Global : public PersistentBase<T> {
*/ */
typedef void MoveOnlyTypeForCPP03; typedef void MoveOnlyTypeForCPP03;
Global(const Global&) = delete;
void operator=(const Global&) = delete;
private: private:
template <class F> template <class F>
friend class ReturnValue; friend class ReturnValue;
Global(const Global&) = delete;
void operator=(const Global&) = delete;
V8_INLINE T* operator*() const { return this->val_; } V8_INLINE T* operator*() const { return this->val_; }
}; };
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment