Commit ce16c04d authored by jameslahm's avatar jameslahm Committed by V8 LUCI CQ

[test] Move cctest/test-intl to unittests/

... objects/intl-unittest.

Bug: v8:12781
Change-Id: I225054f5d0071f28d5b4d1efe8698ce5d0276c0c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3725448Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
Commit-Queue: 王澳 <wangao.james@bytedance.com>
Cr-Commit-Position: refs/heads/main@{#81534}
parent 7890a89d
...@@ -191,7 +191,6 @@ v8_source_set("cctest_sources") { ...@@ -191,7 +191,6 @@ v8_source_set("cctest_sources") {
"test-ignition-statistics-extension.cc", "test-ignition-statistics-extension.cc",
"test-inobject-slack-tracking.cc", "test-inobject-slack-tracking.cc",
"test-inspector.cc", "test-inspector.cc",
"test-intl.cc",
"test-js-weak-refs.cc", "test-js-weak-refs.cc",
"test-liveedit.cc", "test-liveedit.cc",
"test-local-handles.cc", "test-local-handles.cc",
...@@ -390,8 +389,6 @@ v8_source_set("cctest_sources") { ...@@ -390,8 +389,6 @@ v8_source_set("cctest_sources") {
if (v8_enable_i18n_support) { if (v8_enable_i18n_support) {
defines += [ "V8_INTL_SUPPORT" ] defines += [ "V8_INTL_SUPPORT" ]
public_deps += [ "//third_party/icu" ] public_deps += [ "//third_party/icu" ]
} else {
sources -= [ "test-intl.cc" ]
} }
cflags = [] cflags = []
......
...@@ -132,8 +132,6 @@ ...@@ -132,8 +132,6 @@
'test-strings/Traverse': [PASS, HEAVY], 'test-strings/Traverse': [PASS, HEAVY],
'test-swiss-name-dictionary-csa/DeleteAtBoundaries': [PASS, HEAVY], 'test-swiss-name-dictionary-csa/DeleteAtBoundaries': [PASS, HEAVY],
'test-swiss-name-dictionary-csa/SameH2': [PASS, HEAVY], 'test-swiss-name-dictionary-csa/SameH2': [PASS, HEAVY],
'test-intl/StringLocaleCompareFastPath': [['mode != release', SKIP], SLOW, NO_VARIANTS],
}], # ALWAYS }], # ALWAYS
############################################################################## ##############################################################################
......
...@@ -430,6 +430,7 @@ v8_source_set("unittests_sources") { ...@@ -430,6 +430,7 @@ v8_source_set("unittests_sources") {
"objects/elements-kind-unittest.cc", "objects/elements-kind-unittest.cc",
"objects/global-object-unittest.cc", "objects/global-object-unittest.cc",
"objects/hashcode-unittest.cc", "objects/hashcode-unittest.cc",
"objects/intl-unittest.cc",
"objects/managed-unittest.cc", "objects/managed-unittest.cc",
"objects/modules-unittest.cc", "objects/modules-unittest.cc",
"objects/object-unittest.cc", "objects/object-unittest.cc",
...@@ -525,6 +526,13 @@ v8_source_set("unittests_sources") { ...@@ -525,6 +526,13 @@ v8_source_set("unittests_sources") {
sources += [ "heap/object-start-bitmap-unittest.cc" ] sources += [ "heap/object-start-bitmap-unittest.cc" ]
} }
if (v8_enable_i18n_support) {
defines = [ "V8_INTL_SUPPORT" ]
public_deps = [ "//third_party/icu" ]
} else {
sources -= [ "objects/intl-unittest.cc" ]
}
if (v8_current_cpu == "arm") { if (v8_current_cpu == "arm") {
sources += [ sources += [
"assembler/disasm-arm-unittest.cc", "assembler/disasm-arm-unittest.cc",
......
This diff is collapsed.
...@@ -16,6 +16,8 @@ ...@@ -16,6 +16,8 @@
# These tests are supposed to fail in a slow DCHECK, skip them otherwise. # These tests are supposed to fail in a slow DCHECK, skip them otherwise.
'PersistentHandlesTest.DereferencePersistentHandleFailsWhenDisallowed': [SKIP, ['mode == debug', FAIL]], 'PersistentHandlesTest.DereferencePersistentHandleFailsWhenDisallowed': [SKIP, ['mode == debug', FAIL]],
'IntlTest.StringLocaleCompareFastPath': [['mode != release', SKIP], SLOW, NO_VARIANTS],
}], # ALWAYS }], # ALWAYS
############################################################################## ##############################################################################
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment