Commit cd139abb authored by Leszek Swirski's avatar Leszek Swirski Committed by Commit Bot

[sparkplug] Change TODO into a comment

The TODO around range checks for LAST_JS_RECEIVER_TYPE is guarded
by a STATIC_ASSERT, so it can be a comment rather than a TODO.

Bug: v8:11429
Change-Id: Id0d7fc9526448319d89cba43d793accf022a949b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692567
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: 's avatarVictor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72709}
parent 88de5b0f
......@@ -1326,8 +1326,8 @@ void BaselineCompiler::VisitIntrinsicIsJSReceiver(
Label is_smi;
__ JumpIfSmi(kInterpreterAccumulatorRegister, &is_smi, Label::kNear);
// TODO(v8:11429,leszeks): If we ever added more instance types after
// LAST_JS_RECEIVER_TYPE, this would have to become a range check.
// If we ever added more instance types after LAST_JS_RECEIVER_TYPE,
// this would have to become a range check.
STATIC_ASSERT(LAST_JS_RECEIVER_TYPE == LAST_TYPE);
__ CmpInstanceType(kInterpreterAccumulatorRegister,
FIRST_JS_RECEIVER_TYPE);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment