Skip to content

V
V8
Commit cc362227 authored by bratell's avatar bratell Committed by Commit bot
Browse files
Options

Make the statistics generation data driven. 

StatisticsExtension::GetCounters() has grown to repeat a lot of code
so to make it more maintainable and generate less machine code,
make it data driven. This makes a 64 bit Linux build 50 KB smaller.

Total change: -51677 bytes
==========================
  1 shrunk, for a net change of -51677 bytes (64222 bytes before, 12545 bytes after) across 1 sources
  279691 unchanged, totalling 51423668 bytes

Per-source Analysis:

-------------------------------------------------------------------------------------------------------------------
 -51677 - Source: /home/bratell/src/chromium/src/v8/src/extensions/statistics-extension.cc - (gained 0, lost 51677)
-------------------------------------------------------------------------------------------------------------------
  Shrunk symbols:
     -51677: v8::internal::StatisticsExtension::GetCounters(v8::FunctionCallbackInfo<v8::Value> const&) type=t, (was 64222 bytes, now 12545 bytes)

BUG=

Review URL: https://codereview.chromium.org/912413003

Cr-Commit-Position: refs/heads/master@{#26640}
parent a82d3dc8
Show whitespace changes
Inline Side-by-side
Showing with 68 additions and 73 deletions
src/extensions/statistics-extension.cc
View file @ cc362227
......@@ -62,86 +62,81 @@ void StatisticsExtension::GetCounters(
Counters* counters = isolate->counters();
v8::Local<v8::Object> result = v8::Object::New(args.GetIsolate());
struct StatisticsCounter {
v8::internal::StatsCounter* counter;
const char* name;
};
const StatisticsCounter counter_list[] = {
#define ADD_COUNTER(name, caption) \
AddCounter(args.GetIsolate(), result, counters->name(), #name);
{ counters->name(), #name } \
,
STATS_COUNTER_LIST_1(ADD_COUNTER)
STATS_COUNTER_LIST_2(ADD_COUNTER)
STATS_COUNTER_LIST_1(ADD_COUNTER) STATS_COUNTER_LIST_2(ADD_COUNTER)
#undef ADD_COUNTER
#define ADD_COUNTER(name) \
AddCounter(args.GetIsolate(), result, counters->count_of_##name(), \
"count_of_" #name); \
AddCounter(args.GetIsolate(), result, counters->size_of_##name(), \
"size_of_" #name);
{ counters->count_of_##name(), "count_of_" #name } \
, {counters->size_of_##name(), "size_of_" #name},
INSTANCE_TYPE_LIST(ADD_COUNTER)
#undef ADD_COUNTER
#define ADD_COUNTER(name) \
AddCounter(args.GetIsolate(), result, counters->count_of_CODE_TYPE_##name(), \
"count_of_CODE_TYPE_" #name); \
AddCounter(args.GetIsolate(), result, counters->size_of_CODE_TYPE_##name(), \
"size_of_CODE_TYPE_" #name);
{ counters->count_of_CODE_TYPE_##name(), "count_of_CODE_TYPE_" #name } \
, {counters->size_of_CODE_TYPE_##name(), "size_of_CODE_TYPE_" #name},
CODE_KIND_LIST(ADD_COUNTER)
#undef ADD_COUNTER
#define ADD_COUNTER(name) \
AddCounter(args.GetIsolate(), result, \
counters->count_of_FIXED_ARRAY_##name(), \
"count_of_FIXED_ARRAY_" #name); \
AddCounter(args.GetIsolate(), result, \
counters->size_of_FIXED_ARRAY_##name(), \
"size_of_FIXED_ARRAY_" #name);
{ counters->count_of_FIXED_ARRAY_##name(), "count_of_FIXED_ARRAY_" #name } \
, {counters->size_of_FIXED_ARRAY_##name(), "size_of_FIXED_ARRAY_" #name},
FIXED_ARRAY_SUB_INSTANCE_TYPE_LIST(ADD_COUNTER)
#undef ADD_COUNTER
}; // End counter_list array.
for (size_t i = 0; i < arraysize(counter_list); i++) {
AddCounter(args.GetIsolate(), result, counter_list[i].counter,
counter_list[i].name);
}
struct StatisticNumber {
intptr_t number;
const char* name;
};
const StatisticNumber numbers[] = {
{isolate->memory_allocator()->Size(), "total_committed_bytes"},
{heap->new_space()->Size(), "new_space_live_bytes"},
{heap->new_space()->Available(), "new_space_available_bytes"},
{heap->new_space()->CommittedMemory(), "new_space_commited_bytes"},
{heap->old_pointer_space()->Size(), "old_pointer_space_live_bytes"},
{heap->old_pointer_space()->Available(),
"old_pointer_space_available_bytes"},
{heap->old_pointer_space()->CommittedMemory(),
"old_pointer_space_commited_bytes"},
{heap->old_data_space()->Size(), "old_data_space_live_bytes"},
{heap->old_data_space()->Available(), "old_data_space_available_bytes"},
{heap->old_data_space()->CommittedMemory(),
"old_data_space_commited_bytes"},
{heap->code_space()->Size(), "code_space_live_bytes"},
{heap->code_space()->Available(), "code_space_available_bytes"},
{heap->code_space()->CommittedMemory(), "code_space_commited_bytes"},
{heap->cell_space()->Size(), "cell_space_live_bytes"},
{heap->cell_space()->Available(), "cell_space_available_bytes"},
{heap->cell_space()->CommittedMemory(), "cell_space_commited_bytes"},
{heap->property_cell_space()->Size(), "property_cell_space_live_bytes"},
{heap->property_cell_space()->Available(),
"property_cell_space_available_bytes"},
{heap->property_cell_space()->CommittedMemory(),
"property_cell_space_commited_bytes"},
{heap->lo_space()->Size(), "lo_space_live_bytes"},
{heap->lo_space()->Available(), "lo_space_available_bytes"},
{heap->lo_space()->CommittedMemory(), "lo_space_commited_bytes"},
};
for (size_t i = 0; i < arraysize(numbers); i++) {
AddNumber(args.GetIsolate(), result, numbers[i].number, numbers[i].name);
}
AddNumber(args.GetIsolate(), result, isolate->memory_allocator()->Size(),
"total_committed_bytes");
AddNumber(args.GetIsolate(), result, heap->new_space()->Size(),
"new_space_live_bytes");
AddNumber(args.GetIsolate(), result, heap->new_space()->Available(),
"new_space_available_bytes");
AddNumber(args.GetIsolate(), result, heap->new_space()->CommittedMemory(),
"new_space_commited_bytes");
AddNumber(args.GetIsolate(), result, heap->old_pointer_space()->Size(),
"old_pointer_space_live_bytes");
AddNumber(args.GetIsolate(), result, heap->old_pointer_space()->Available(),
"old_pointer_space_available_bytes");
AddNumber(args.GetIsolate(), result,
heap->old_pointer_space()->CommittedMemory(),
"old_pointer_space_commited_bytes");
AddNumber(args.GetIsolate(), result, heap->old_data_space()->Size(),
"old_data_space_live_bytes");
AddNumber(args.GetIsolate(), result, heap->old_data_space()->Available(),
"old_data_space_available_bytes");
AddNumber(args.GetIsolate(), result,
heap->old_data_space()->CommittedMemory(),
"old_data_space_commited_bytes");
AddNumber(args.GetIsolate(), result, heap->code_space()->Size(),
"code_space_live_bytes");
AddNumber(args.GetIsolate(), result, heap->code_space()->Available(),
"code_space_available_bytes");
AddNumber(args.GetIsolate(), result, heap->code_space()->CommittedMemory(),
"code_space_commited_bytes");
AddNumber(args.GetIsolate(), result, heap->cell_space()->Size(),
"cell_space_live_bytes");
AddNumber(args.GetIsolate(), result, heap->cell_space()->Available(),
"cell_space_available_bytes");
AddNumber(args.GetIsolate(), result, heap->cell_space()->CommittedMemory(),
"cell_space_commited_bytes");
AddNumber(args.GetIsolate(), result, heap->property_cell_space()->Size(),
"property_cell_space_live_bytes");
AddNumber(args.GetIsolate(), result, heap->property_cell_space()->Available(),
"property_cell_space_available_bytes");
AddNumber(args.GetIsolate(), result,
heap->property_cell_space()->CommittedMemory(),
"property_cell_space_commited_bytes");
AddNumber(args.GetIsolate(), result, heap->lo_space()->Size(),
"lo_space_live_bytes");
AddNumber(args.GetIsolate(), result, heap->lo_space()->Available(),
"lo_space_available_bytes");
AddNumber(args.GetIsolate(), result, heap->lo_space()->CommittedMemory(),
"lo_space_commited_bytes");
AddNumber64(args.GetIsolate(), result,
heap->amount_of_external_allocated_memory(),
"amount_of_external_allocated_memory");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment