[wasm] Remove obsolete runtime stubs that just tail-call.

Now that all builtins are embedded, it is no longer needed to have a
fallback variant where WebAssembly runtime stubs tail-call existing
(non-embedded) builtins, just call the (embedded) builtin directly.

R=clemensb@chromium.org
BUG=v8:6666,v8:9810

Change-Id: Id8a2b2089cabc77f841f484986d8212ca2918ef4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1883550
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64581}

src/builtins/builtins-definitions.h

@@ -949,17 +949,14 @@ namespace internal {
                                                                                \
   /* Wasm */                                                                   \
   ASM(WasmCompileLazy, Dummy)                                                  \
-  TFC(WasmAllocateHeapNumber, AllocateHeapNumber)                              \
   TFC(WasmAtomicNotify, WasmAtomicNotify)                                      \
   TFC(WasmI32AtomicWait, WasmI32AtomicWait)                                    \
   TFC(WasmI64AtomicWait, WasmI64AtomicWait)                                    \
   TFC(WasmMemoryGrow, WasmMemoryGrow)                                          \
   TFC(WasmTableGet, WasmTableGet)                                              \
   TFC(WasmTableSet, WasmTableSet)                                              \
-  TFC(WasmRecordWrite, RecordWrite)                                            \
   TFC(WasmStackGuard, NoContext)                                               \
   TFC(WasmStackOverflow, NoContext)                                            \
-  TFC(WasmToNumber, TypeConversion)                                            \
   TFC(WasmThrow, WasmThrow)                                                    \
   TFC(WasmRethrow, WasmThrow)                                                  \
   TFS(ThrowWasmTrapUnreachable)                                                \
@@ -974,10 +971,6 @@ namespace internal {
   TFS(ThrowWasmTrapDataSegmentDropped)                                         \
   TFS(ThrowWasmTrapElemSegmentDropped)                                         \
   TFS(ThrowWasmTrapTableOutOfBounds)                                           \
-  TFC(WasmI64ToBigInt, I64ToBigInt)                                            \
-  TFC(WasmI32PairToBigInt, I32PairToBigInt)                                    \
-  TFC(WasmBigIntToI64, BigIntToI64)                                            \
-  TFC(WasmBigIntToI32Pair, BigIntToI32Pair)                                    \
                                                                                \
   /* WeakMap */                                                                \
   TFJ(WeakMapConstructor, SharedFunctionInfo::kDontAdaptArgumentsSentinel)     \
@@ -1270,25 +1263,25 @@ namespace internal {
 #define WASM_RUNTIME_STUB_LIST(V, VTRAP) \
   FOREACH_WASM_TRAPREASON(VTRAP)         \
   V(WasmCompileLazy)                     \
-  V(WasmAllocateHeapNumber)              \
   V(WasmAtomicNotify)                    \
   V(WasmI32AtomicWait)                   \
   V(WasmI64AtomicWait)                   \
   V(WasmMemoryGrow)                      \
   V(WasmTableGet)                        \
   V(WasmTableSet)                        \
-  V(WasmRecordWrite)                     \
   V(WasmStackGuard)                      \
   V(WasmStackOverflow)                   \
-  V(WasmToNumber)                        \
   V(WasmThrow)                           \
   V(WasmRethrow)                         \
+  V(AllocateHeapNumber)                  \
   V(ArgumentsAdaptorTrampoline)          \
+  V(BigIntToI32Pair)                     \
+  V(BigIntToI64)                         \
   V(DoubleToI)                           \
-  V(WasmI64ToBigInt)                     \
-  V(WasmI32PairToBigInt)                 \
-  V(WasmBigIntToI64)                     \
-  V(WasmBigIntToI32Pair)
+  V(I32PairToBigInt)                     \
+  V(I64ToBigInt)                         \
+  V(RecordWrite)                         \
+  V(ToNumber)
 
 // The exception thrown in the following builtins are caught internally and will
 // not be propagated further or re-thrown

src/builtins/builtins-wasm-gen.cc

@@ -60,28 +60,6 @@ class WasmBuiltinsAssembler : public CodeStubAssembler {
   }
 };
 
-TF_BUILTIN(WasmAllocateHeapNumber, WasmBuiltinsAssembler) {
-  TNode<Code> target = LoadBuiltinFromFrame(Builtins::kAllocateHeapNumber);
-  TailCallStub(AllocateHeapNumberDescriptor(), target, NoContextConstant());
-}
-
-TF_BUILTIN(WasmRecordWrite, WasmBuiltinsAssembler) {
-  TNode<Object> object = UncheckedParameter(Descriptor::kObject);
-  TNode<Object> slot = UncheckedParameter(Descriptor::kSlot);
-  TNode<Object> remembered = UncheckedParameter(Descriptor::kRememberedSet);
-  TNode<Object> fp_mode = UncheckedParameter(Descriptor::kFPMode);
-  TNode<Code> target = LoadBuiltinFromFrame(Builtins::kRecordWrite);
-  TailCallStub(RecordWriteDescriptor{}, target, NoContextConstant(), object,
-               slot, remembered, fp_mode);
-}
-
-TF_BUILTIN(WasmToNumber, WasmBuiltinsAssembler) {
-  TNode<Object> context = UncheckedParameter(Descriptor::kContext);
-  TNode<Object> argument = UncheckedParameter(Descriptor::kArgument);
-  TNode<Code> target = LoadBuiltinFromFrame(Builtins::kToNumber);
-  TailCallStub(TypeConversionDescriptor(), target, context, argument);
-}
-
 TF_BUILTIN(WasmStackGuard, WasmBuiltinsAssembler) {
   TNode<Object> instance = LoadInstanceFromFrame();
   TNode<Code> centry = LoadCEntryFromInstance(instance);
@@ -285,63 +263,6 @@ TF_BUILTIN(WasmTableSet, WasmBuiltinsAssembler) {
                             SmiConstant(static_cast<int>(message_id)));
 }
 
-TF_BUILTIN(WasmI64ToBigInt, WasmBuiltinsAssembler) {
-  if (!Is64()) {
-    Unreachable();
-    return;
-  }
-
-  TNode<Code> target = LoadBuiltinFromFrame(Builtins::kI64ToBigInt);
-  TNode<IntPtrT> argument =
-      UncheckedCast<IntPtrT>(Parameter(Descriptor::kArgument));
-
-  TailCallStub(I64ToBigIntDescriptor(), target, NoContextConstant(), argument);
-}
-
-TF_BUILTIN(WasmI32PairToBigInt, WasmBuiltinsAssembler) {
-  if (!Is32()) {
-    Unreachable();
-    return;
-  }
-
-  TNode<Code> target = LoadBuiltinFromFrame(Builtins::kI32PairToBigInt);
-  TNode<IntPtrT> low = UncheckedCast<IntPtrT>(Parameter(Descriptor::kLow));
-  TNode<IntPtrT> high = UncheckedCast<IntPtrT>(Parameter(Descriptor::kHigh));
-
-  TailCallStub(I32PairToBigIntDescriptor(), target, NoContextConstant(), low,
-               high);
-}
-
-TF_BUILTIN(WasmBigIntToI64, WasmBuiltinsAssembler) {
-  if (!Is64()) {
-    Unreachable();
-    return;
-  }
-
-  TNode<Object> context =
-      UncheckedCast<Object>(Parameter(Descriptor::kContext));
-  TNode<Code> target = LoadBuiltinFromFrame(Builtins::kBigIntToI64);
-  TNode<IntPtrT> argument =
-      UncheckedCast<IntPtrT>(Parameter(Descriptor::kArgument));
-
-  TailCallStub(BigIntToI64Descriptor(), target, context, argument);
-}
-
-TF_BUILTIN(WasmBigIntToI32Pair, WasmBuiltinsAssembler) {
-  if (!Is32()) {
-    Unreachable();
-    return;
-  }
-
-  TNode<Object> context =
-      UncheckedCast<Object>(Parameter(Descriptor::kContext));
-  TNode<Code> target = LoadBuiltinFromFrame(Builtins::kBigIntToI32Pair);
-  TNode<IntPtrT> argument =
-      UncheckedCast<IntPtrT>(Parameter(Descriptor::kArgument));
-
-  TailCallStub(BigIntToI32PairDescriptor(), target, context, argument);
-}
-
 #define DECLARE_ENUM(name)                                                \
   TF_BUILTIN(ThrowWasm##name, WasmBuiltinsAssembler) {                    \
     TNode<Object> instance = LoadInstanceFromFrame();                     \

src/compiler/backend/arm/code-generator-arm.cc

@@ -200,7 +200,7 @@ class OutOfLineRecordWrite final : public OutOfLineCode {
       __ CallEphemeronKeyBarrier(object_, offset_, save_fp_mode);
     } else if (stub_mode_ == StubCallMode::kCallWasmRuntimeStub) {
       __ CallRecordWriteStub(object_, offset_, remembered_set_action,
-                             save_fp_mode, wasm::WasmCode::kWasmRecordWrite);
+                             save_fp_mode, wasm::WasmCode::kRecordWrite);
     } else {
       __ CallRecordWriteStub(object_, offset_, remembered_set_action,
                              save_fp_mode);

src/compiler/backend/arm64/code-generator-arm64.cc

@@ -301,7 +301,7 @@ class OutOfLineRecordWrite final : public OutOfLineCode {
       // Just encode the stub index. This will be patched when the code
       // is added to the native module and copied into wasm code space.
       __ CallRecordWriteStub(object_, offset_, remembered_set_action,
-                             save_fp_mode, wasm::WasmCode::kWasmRecordWrite);
+                             save_fp_mode, wasm::WasmCode::kRecordWrite);
     } else {
       __ CallRecordWriteStub(object_, offset_, remembered_set_action,
                              save_fp_mode);

src/compiler/backend/ia32/code-generator-ia32.cc

@@ -321,7 +321,7 @@ class OutOfLineRecordWrite final : public OutOfLineCode {
       // Just encode the stub index. This will be patched when the code
       // is added to the native module and copied into wasm code space.
       __ CallRecordWriteStub(object_, scratch1_, remembered_set_action,
-                             save_fp_mode, wasm::WasmCode::kWasmRecordWrite);
+                             save_fp_mode, wasm::WasmCode::kRecordWrite);
     } else {
       __ CallRecordWriteStub(object_, scratch1_, remembered_set_action,
                              save_fp_mode);

src/compiler/backend/mips/code-generator-mips.cc

@@ -179,7 +179,7 @@ class OutOfLineRecordWrite final : public OutOfLineCode {
       // Just encode the stub index. This will be patched when the code
       // is added to the native module and copied into wasm code space.
       __ CallRecordWriteStub(object_, scratch1_, remembered_set_action,
-                             save_fp_mode, wasm::WasmCode::kWasmRecordWrite);
+                             save_fp_mode, wasm::WasmCode::kRecordWrite);
     } else {
       __ CallRecordWriteStub(object_, scratch1_, remembered_set_action,
                              save_fp_mode);

src/compiler/backend/mips64/code-generator-mips64.cc

@@ -180,7 +180,7 @@ class OutOfLineRecordWrite final : public OutOfLineCode {
       // Just encode the stub index. This will be patched when the code
       // is added to the native module and copied into wasm code space.
       __ CallRecordWriteStub(object_, scratch1_, remembered_set_action,
-                             save_fp_mode, wasm::WasmCode::kWasmRecordWrite);
+                             save_fp_mode, wasm::WasmCode::kRecordWrite);
     } else {
       __ CallRecordWriteStub(object_, scratch1_, remembered_set_action,
                              save_fp_mode);

src/compiler/backend/ppc/code-generator-ppc.cc

@@ -185,7 +185,7 @@ class OutOfLineRecordWrite final : public OutOfLineCode {
       __ CallEphemeronKeyBarrier(object_, scratch1_, save_fp_mode);
     } else if (stub_mode_ == StubCallMode::kCallWasmRuntimeStub) {
       __ CallRecordWriteStub(object_, scratch1_, remembered_set_action,
-                             save_fp_mode, wasm::WasmCode::kWasmRecordWrite);
+                             save_fp_mode, wasm::WasmCode::kRecordWrite);
     } else {
       __ CallRecordWriteStub(object_, scratch1_, remembered_set_action,
                              save_fp_mode);

src/compiler/backend/s390/code-generator-s390.cc

@@ -222,7 +222,7 @@ class OutOfLineRecordWrite final : public OutOfLineCode {
       __ CallEphemeronKeyBarrier(object_, scratch1_, save_fp_mode);
     } else if (stub_mode_ == StubCallMode::kCallWasmRuntimeStub) {
       __ CallRecordWriteStub(object_, scratch1_, remembered_set_action,
-                             save_fp_mode, wasm::WasmCode::kWasmRecordWrite);
+                             save_fp_mode, wasm::WasmCode::kRecordWrite);
     } else {
       __ CallRecordWriteStub(object_, scratch1_, remembered_set_action,
                              save_fp_mode);

src/compiler/backend/x64/code-generator-x64.cc

@@ -280,7 +280,7 @@ class OutOfLineRecordWrite final : public OutOfLineCode {
       // Just encode the stub index. This will be patched when the code
       // is added to the native module and copied into wasm code space.
       __ CallRecordWriteStub(object_, scratch1_, remembered_set_action,
-                             save_fp_mode, wasm::WasmCode::kWasmRecordWrite);
+                             save_fp_mode, wasm::WasmCode::kRecordWrite);
     } else {
       __ CallRecordWriteStub(object_, scratch1_, remembered_set_action,
                              save_fp_mode);

src/compiler/wasm-compiler.cc

@@ -5184,7 +5184,7 @@ class WasmWrapperGraphBuilder : public WasmGraphBuilder {
     Node* target =
         (stub_mode_ == StubCallMode::kCallWasmRuntimeStub)
             ? mcgraph()->RelocatableIntPtrConstant(
-                  wasm::WasmCode::kWasmAllocateHeapNumber,
+                  wasm::WasmCode::kAllocateHeapNumber,
                   RelocInfo::WASM_STUB_CALL)
             : BuildLoadBuiltinFromIsolateRoot(Builtins::kAllocateHeapNumber);
     if (!allocate_heap_number_operator_.is_set()) {
@@ -5388,8 +5388,8 @@ class WasmWrapperGraphBuilder : public WasmGraphBuilder {
         CallDescriptor::kNoFlags, Operator::kNoProperties, stub_mode_);
     Node* stub_code =
         (stub_mode_ == StubCallMode::kCallWasmRuntimeStub)
-            ? mcgraph()->RelocatableIntPtrConstant(
-                  wasm::WasmCode::kWasmToNumber, RelocInfo::WASM_STUB_CALL)
+            ? mcgraph()->RelocatableIntPtrConstant(wasm::WasmCode::kToNumber,
+                                                   RelocInfo::WASM_STUB_CALL)
             : BuildLoadBuiltinFromIsolateRoot(Builtins::kToNumber);
 
     Node* result = SetEffect(
@@ -5483,7 +5483,7 @@ class WasmWrapperGraphBuilder : public WasmGraphBuilder {
       target =
           (stub_mode_ == StubCallMode::kCallWasmRuntimeStub)
               ? mcgraph()->RelocatableIntPtrConstant(
-                    wasm::WasmCode::kWasmI64ToBigInt, RelocInfo::WASM_STUB_CALL)
+                    wasm::WasmCode::kI64ToBigInt, RelocInfo::WASM_STUB_CALL)
               : BuildLoadBuiltinFromIsolateRoot(Builtins::kI64ToBigInt);
     } else {
       DCHECK(mcgraph()->machine()->Is32());
@@ -5493,8 +5493,7 @@ class WasmWrapperGraphBuilder : public WasmGraphBuilder {
       target =
           (stub_mode_ == StubCallMode::kCallWasmRuntimeStub)
               ? mcgraph()->RelocatableIntPtrConstant(
-                    wasm::WasmCode::kWasmI32PairToBigInt,
-                    RelocInfo::WASM_STUB_CALL)
+                    wasm::WasmCode::kI32PairToBigInt, RelocInfo::WASM_STUB_CALL)
               : BuildLoadBuiltinFromIsolateRoot(Builtins::kI32PairToBigInt);
     }
 
@@ -5511,7 +5510,7 @@ class WasmWrapperGraphBuilder : public WasmGraphBuilder {
       target =
           (stub_mode_ == StubCallMode::kCallWasmRuntimeStub)
               ? mcgraph()->RelocatableIntPtrConstant(
-                    wasm::WasmCode::kWasmBigIntToI64, RelocInfo::WASM_STUB_CALL)
+                    wasm::WasmCode::kBigIntToI64, RelocInfo::WASM_STUB_CALL)
               : BuildLoadBuiltinFromIsolateRoot(Builtins::kBigIntToI64);
     } else {
       DCHECK(mcgraph()->machine()->Is32());
@@ -5521,8 +5520,7 @@ class WasmWrapperGraphBuilder : public WasmGraphBuilder {
       target =
           (stub_mode_ == StubCallMode::kCallWasmRuntimeStub)
               ? mcgraph()->RelocatableIntPtrConstant(
-                    wasm::WasmCode::kWasmBigIntToI32Pair,
-                    RelocInfo::WASM_STUB_CALL)
+                    wasm::WasmCode::kBigIntToI32Pair, RelocInfo::WASM_STUB_CALL)
               : BuildLoadBuiltinFromIsolateRoot(Builtins::kBigIntToI32Pair);
     }