Commit c90f077f authored by Leszek Swirski's avatar Leszek Swirski Committed by V8 LUCI CQ

[sparkplug] Clear exceptions on failed %CompileBaseline

This is for tests only, and in those tests it should crash, while
on fuzzers it should silently fail. For those failing cases, we
should clear the exception so that the runtime call isn't confused

Bug: chromium:1244254
Change-Id: I5bb1c50d1538331dd9298911d742530b9769be8d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3127714
Commit-Queue: Patrick Thier <pthier@chromium.org>
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: 's avatarPatrick Thier <pthier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76566}
parent 91b72485
......@@ -373,12 +373,12 @@ RUNTIME_FUNCTION(Runtime_CompileBaseline) {
// First compile the bytecode, if we have to.
if (!is_compiled_scope.is_compiled() &&
!Compiler::Compile(isolate, function, Compiler::KEEP_EXCEPTION,
!Compiler::Compile(isolate, function, Compiler::CLEAR_EXCEPTION,
&is_compiled_scope)) {
return CrashUnlessFuzzing(isolate);
}
if (!Compiler::CompileBaseline(isolate, function, Compiler::KEEP_EXCEPTION,
if (!Compiler::CompileBaseline(isolate, function, Compiler::CLEAR_EXCEPTION,
&is_compiled_scope)) {
return CrashUnlessFuzzing(isolate);
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment