Commit c8cff606 authored by kozyatinskiy's avatar kozyatinskiy Committed by Commit bot

[inspector] remove profiler->collectSample from V8StackTraceImpl::capture

Now we don't need to call collectSample on each V8StackTraceImpl::capture during collecting profile.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=none
R=alph@chromium.org,dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2510823002
Cr-Commit-Position: refs/heads/master@{#41051}
parent 1160e5ed
...@@ -309,8 +309,4 @@ bool V8ProfilerAgentImpl::idleFinished() { ...@@ -309,8 +309,4 @@ bool V8ProfilerAgentImpl::idleFinished() {
return m_profiler; return m_profiler;
} }
void V8ProfilerAgentImpl::collectSample() {
if (m_profiler) m_profiler->CollectSample();
}
} // namespace v8_inspector } // namespace v8_inspector
...@@ -43,8 +43,6 @@ class V8ProfilerAgentImpl : public protocol::Profiler::Backend { ...@@ -43,8 +43,6 @@ class V8ProfilerAgentImpl : public protocol::Profiler::Backend {
bool idleStarted(); bool idleStarted();
bool idleFinished(); bool idleFinished();
void collectSample();
private: private:
String16 nextProfileId(); String16 nextProfileId();
......
...@@ -7,10 +7,8 @@ ...@@ -7,10 +7,8 @@
#include "src/inspector/string-util.h" #include "src/inspector/string-util.h"
#include "src/inspector/v8-debugger.h" #include "src/inspector/v8-debugger.h"
#include "src/inspector/v8-inspector-impl.h" #include "src/inspector/v8-inspector-impl.h"
#include "src/inspector/v8-profiler-agent-impl.h"
#include "include/v8-debug.h" #include "include/v8-debug.h"
#include "include/v8-profiler.h"
#include "include/v8-version.h" #include "include/v8-version.h"
namespace v8_inspector { namespace v8_inspector {
...@@ -161,12 +159,6 @@ std::unique_ptr<V8StackTraceImpl> V8StackTraceImpl::capture( ...@@ -161,12 +159,6 @@ std::unique_ptr<V8StackTraceImpl> V8StackTraceImpl::capture(
v8::HandleScope handleScope(isolate); v8::HandleScope handleScope(isolate);
v8::Local<v8::StackTrace> stackTrace; v8::Local<v8::StackTrace> stackTrace;
if (isolate->InContext()) { if (isolate->InContext()) {
if (debugger) {
V8InspectorImpl* inspector = debugger->inspector();
V8ProfilerAgentImpl* profilerAgent =
inspector->enabledProfilerAgentForGroup(contextGroupId);
if (profilerAgent) profilerAgent->collectSample();
}
stackTrace = v8::StackTrace::CurrentStackTrace( stackTrace = v8::StackTrace::CurrentStackTrace(
isolate, static_cast<int>(maxStackSize), stackTraceOptions); isolate, static_cast<int>(maxStackSize), stackTraceOptions);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment